[release/6.0] HTTP/3: Support canceling requests that aren't reading a body #36109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
BrennanConroy,
Tratcher and
halter73
as code owners
adityamandaleeka
approved these changes
Sep 2, 2021
halter73
approved these changes
Sep 3, 2021
Member
Author
|
@wtgodbe Can you merge please 🙏 |
ghost
added this to the
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36017 to release/6.0
Customer Impact
HTTP/3 requests that have been canceled or aborted after the incoming request body is read weren't being correctly removed on the server. This could cause some canceled HTTP requests to hang around on the server, using up resources and creating a memory leak. There is the opportunity for malicious clients to use this to DOS attack the server.
Testing
Functional tests. Also tested with grpc-dotnet.
Risk
Medium-Low. The HTTP/3 abort logic has non-trivial changes. To account for this, the changes have been well tested and reviewed by Kestrel SMEs.
Change is constrained to HTTP/3.