Add support for stating accepts/consumes metadata is required or not #35875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafikiassumani-msft
requested review from
BrennanConroy,
Pilchie,
Tratcher,
javiercn and
pranavkm
as code owners
DamianEdwards
requested changes
Aug 28, 2021
src/Mvc/Mvc.Core/src/Builder/OpenApiEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Mvc/Mvc.Core/src/Builder/OpenApiEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Mvc/Mvc.Core/src/Builder/OpenApiEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Mvc/Mvc.Core/src/Builder/OpenApiEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Mvc/Mvc.Core/src/Builder/OpenApiEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Mvc/Mvc.Core/src/Builder/OpenApiEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Mvc/Mvc.Core/src/Builder/OpenApiEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Aug 28, 2021
src/Mvc/Mvc.ApiExplorer/src/EndpointMetadataApiDescriptionProvider.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Aug 28, 2021
src/Mvc/Mvc.ApiExplorer/src/EndpointMetadataApiDescriptionProvider.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Aug 28, 2021
src/Mvc/Mvc.ApiExplorer/src/EndpointMetadataApiDescriptionProvider.cs
Outdated
Show resolved
Hide resolved
Kahbazi
reviewed
Aug 28, 2021
src/Mvc/Mvc.Core/src/Builder/OpenApiEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Mvc/Mvc.Core/src/Builder/OpenApiEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
pranavkm
reviewed
Aug 28, 2021
src/Mvc/Mvc.ApiExplorer/src/EndpointMetadataApiDescriptionProvider.cs
Outdated
Show resolved
Hide resolved
src/Mvc/Mvc.Core/src/Builder/OpenApiEndpointConventionBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
Pilchie
added
the
old-area-web-frameworks-do-not-use
pranavkm
reviewed
Aug 30, 2021
Kahbazi
reviewed
Aug 30, 2021
pranavkm
approved these changes
Aug 30, 2021
src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
Show resolved
Hide resolved
src/Mvc/Mvc.Core/src/Builder/OpenApiEndpointConventionBuilderExtensions.cs
Show resolved
Hide resolved
src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
Show resolved
Hide resolved
halter73
reviewed
Sep 3, 2021
src/Http/Routing/test/UnitTests/Builder/DelegateEndpointRouteBuilderExtensionsTest.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Sep 3, 2021
src/Mvc/Mvc.ApiExplorer/src/EndpointMetadataApiDescriptionProvider.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Sep 3, 2021
src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
Outdated
Show resolved
Hide resolved
halter73
reviewed
Sep 3, 2021
src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
Show resolved
Hide resolved
halter73
reviewed
Sep 3, 2021
src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
Show resolved
Hide resolved
halter73
reviewed
Sep 3, 2021
src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Sep 3, 2021
davidfowl
reviewed
Sep 3, 2021
Kahbazi
reviewed
Sep 3, 2021
davidfowl
reviewed
Sep 3, 2021
src/Mvc/Mvc.ApiExplorer/src/EndpointMetadataApiDescriptionProvider.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Sep 3, 2021
src/Mvc/Mvc.ApiExplorer/test/EndpointMetadataApiDescriptionProviderTest.cs
Outdated
Show resolved
Hide resolved
davidfowl
approved these changes
Sep 3, 2021
Contributor
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1199180364 |
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Add support for stating accepts/consumes metadata is required or not
PR Description
This PR uses
AcceptsMetatafor extensions method ratherConsumesAttributeFixes #35849