Avoid using new C# language features in Razor code generation #35680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated code for tag helpers is used all the way back in 3.1 which defaults to C# 8. Our code generation currently produces a target-typed new expression that is available in C# 10. Updating some of the older tests to pin the language to a fixed version so we can catch these kinds of regressions as part of tests. Fixes #35554
ghost
added
the
area-mvc
captainsafia
approved these changes
Aug 25, 2021
Contributor
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1166781918 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated code for tag helpers is used all the way back in 3.1 which defaults to C# 8. Our code generation
currently produces a target-typed new expression that is available in C# 10.
Updating some of the older tests to pin the language to a fixed version so we can catch these kinds of regressions as part of tests.
Fixes #35554