Fix 'HeadOutlet' getting trimmed away for Blazor WebAssembly prerendered apps after publish #35419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pranavkm
reviewed
Aug 17, 2021
src/Components/WebAssembly/WebAssembly/src/Hosting/WebAssemblyHostBuilder.cs
Show resolved
Hide resolved
src/Components/WebAssembly/testassets/WasmPrerendered.Client/WasmPrerendered.Client.csproj
Outdated
Show resolved
Hide resolved
SteveSandersonMS
approved these changes
Aug 23, 2021
Member
SteveSandersonMS
left a comment
SteveSandersonMS
left a comment
There was a problem hiding this comment.
Looks great - thanks for sorting this out!
MackinnonBuck
added a commit
that referenced
this pull request
Aug 24, 2021
…red apps after publish (#35419)
Member
Author
|
/backport to release/6.0 |
|
Hi @MackinnonBuck. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1164042744 |
Contributor
|
@MackinnonBuck backporting to release/6.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Update WebAssemblyHostBuilder.cs
Applying: Added comment
Applying: Added E2E test and exception message
Using index info to reconstruct a base tree...
M AspNetCore.sln
M src/Components/Components.slnf
Falling back to patching base and 3-way merge...
Auto-merging src/Components/Components.slnf
Auto-merging AspNetCore.sln
CONFLICT (content): Merge conflict in AspNetCore.sln
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 Added E2E test and exception message
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
HeadOutletgetting trimmed away for Blazor WebAssembly prerendered apps after publishThe
HeadOutletcomponent was getting trimmed away in published ASP.NET Core hosted Blazor WebAssembly prerendered apps. This caused<HeadContent>and<PageTitle>to take effect only during prerendering.PR Description
Added a
[DynamicDependency]onWebAssemblyHostBuilder.CreateDefaultto preventHeadOutletfrom getting trimmed away.Fixes #35363