Add an analyzer that complains when using using model binding attributes with a minimal action delegate #35359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Aug 16, 2021
src/Framework/Analyzer/src/MinimalActions/DiagnosticDescriptors.cs
Outdated
Show resolved
Hide resolved
* [x] Complain when using MVC binding attributes with minimal action * [x] Complain if a route parameter is not used or cannot be bound.
pranavkm
force-pushed
the
prkrishn/analyzer
branch
from
61a276b to
6561769
Compare
pranavkm
changed the title
pranavkm
requested review from
a team,
Pilchie,
dougbu and
javiercn
as code owners
src/Framework/Analyzer/src/MinimalActions/DiagnosticDescriptors.cs
Outdated
Show resolved
Hide resolved
src/Framework/Analyzer/test/MinimalActions/DisallowMvcBindArgumentsOnParametersTest.cs
Show resolved
Hide resolved
src/Framework/Analyzer/test/MinimalActions/RouteAttributeMismatchTest.cs
Outdated
Show resolved
Hide resolved
src/Framework/Analyzer/test/MinimalActions/RouteAttributeMismatchTest.cs
Outdated
Show resolved
Hide resolved
pranavkm
force-pushed
the
prkrishn/analyzer
branch
from
6561769 to
f2a1401
Compare
pranavkm
commented
Aug 18, 2021
BrennanConroy
approved these changes
Aug 18, 2021
Member
BrennanConroy
left a comment
BrennanConroy
left a comment
There was a problem hiding this comment.
Is there a way to do full end to end tests? Otherwise we're just hoping the packaging works correctly and we don't accidentally break it in the future.
src/Framework/Analyzer/src/MinimalActions/DiagnosticDescriptors.cs
Outdated
Show resolved
Hide resolved
Member
|
/backport to release/6.0-rc1 |
Contributor
|
Started backporting to release/6.0-rc1: https://github.com/dotnet/aspnetcore/actions/runs/1145070080 |
Contributor
|
@BrennanConroy backporting to release/6.0-rc1 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Add some analyzers
Applying: Fixup
Using index info to reconstruct a base tree...
M src/Framework/App.Ref/src/Microsoft.AspNetCore.App.Ref.csproj
Falling back to patching base and 3-way merge...
Auto-merging src/Framework/App.Ref/src/Microsoft.AspNetCore.App.Ref.csproj
CONFLICT (content): Merge conflict in src/Framework/App.Ref/src/Microsoft.AspNetCore.App.Ref.csproj
Removing src/Framework/Analyzer/test/MinimalActions/RouteAttributeMismatchTest.cs
Removing src/Framework/Analyzer/src/MinimalActions/RouteAttributeMismatch.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Fixup
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
ghost
added this to the
1 task
wtgodbe
pushed a commit
that referenced
this pull request
Aug 19, 2021
…tes with a minimal action delegate (#35359) (#35480) * [x] Complain when using MVC binding attributes with minimal action Fixes #35088 Co-authored-by: Pranav K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35088