Skip to content

Change route and query fallback semantics #35317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidfowl merged 5 commits into from
Aug 14, 2021
Merged

Change route and query fallback semantics #35317

davidfowl merged 5 commits into from
Aug 14, 2021

Conversation

@davidfowl
Copy link
Member

@davidfowl davidfowl commented Aug 13, 2021

  • If the list of route paramters is empty then simple parameters are from query only.
  • If the list of route parameters is null then fallback from route to query.
  • Added tests.

@davidfowl
Change route and query fallback semantics
f4a1590 
- If the list of route paramters is empty then simple parameters are from query only.
- If the list of route parameters is null then fallback from route to query.
- Added tests.
@ghost ghost added the area-runtime label Aug 13, 2021
davidfowl
davidfowl commented Aug 13, 2021
View reviewed changes
davidfowl
davidfowl commented Aug 13, 2021
View reviewed changes
davidfowl
davidfowl commented Aug 13, 2021
View reviewed changes
@davidfowl davidfowl added feature-minimal-actions Controller-like actions for endpoint routing old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels and removed area-runtime labels Aug 13, 2021
BrennanConroy
BrennanConroy approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from new eyes to this code

pranavkm
pranavkm approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@pranavkm pranavkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine. Could do with more tests

@davidfowl davidfowl enabled auto-merge (squash) August 14, 2021 02:00
@davidfowl davidfowl merged commit bcfbd5c into main Aug 14, 2021
@davidfowl davidfowl deleted the davidfowl/specifically-query branch August 14, 2021 03:30
@ghost ghost added this to the 6.0-rc1 milestone Aug 14, 2021
@amcasey amcasey added the area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@javiercn javiercn Awaiting requested review from javiercn

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

+1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-minimal-actions Controller-like actions for endpoint routing old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels

Projects

None yet

Milestone

6.0-rc1

Development

Successfully merging this pull request may close these issues.

5 participants

@davidfowl @pranavkm @BrennanConroy @amcasey