Skip to content

Fix template css issues #35296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SteveSandersonMS merged 6 commits into from
Aug 12, 2021
Merged

Fix template css issues #35296

SteveSandersonMS merged 6 commits into from
Aug 12, 2021

Conversation

@SteveSandersonMS
Copy link
Member

@SteveSandersonMS SteveSandersonMS commented Aug 12, 2021

Fixes some CSS issues I noticed since the Bootstrap 5 update. It's things to do with margins/padding (Bootstrap has changed the utility class names), link underlining, and handling text that's too wide for the screen.

@SteveSandersonMS SteveSandersonMS requested a review from a team August 12, 2021 17:03
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Aug 12, 2021
@SteveSandersonMS SteveSandersonMS mentioned this pull request Aug 12, 2021
Merged
@SteveSandersonMS SteveSandersonMS added area-blazor Includes: Blazor, Razor Components and removed area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Aug 12, 2021
@SteveSandersonMS SteveSandersonMS self-assigned this Aug 12, 2021
@SteveSandersonMS SteveSandersonMS added this to the 6.0-rc1 milestone Aug 12, 2021
javiercn
javiercn approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rendered all the CSS in my head and it looks great!

@javiercn
Copy link
Member

javiercn commented Aug 12, 2021

/cc: @HaoK

@HaoK
Copy link
Member

HaoK commented Aug 12, 2021

Thanks for addressing these @SteveSandersonMS ! Do you think any of these would also be useful for the other templates or are the padding/spacing in mvc/blazorserver completely different?

@SteveSandersonMS
Copy link
Member Author

SteveSandersonMS commented Aug 12, 2021

Do you think any of these would also be useful for the other templates or are the padding/spacing in mvc/blazorserver completely different?

This PR does update the Blazor Server template too. As for MVC, I didn't find any cases where it was using ml-*, mr-*, pl-*, or pr-*, which are the utility classes that Bootstrap 5 has renamed.

@ghost
Copy link

ghost commented Aug 12, 2021

Hello @SteveSandersonMS!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@SteveSandersonMS SteveSandersonMS merged commit 405567f into main Aug 12, 2021
@SteveSandersonMS SteveSandersonMS deleted the stevesa/fix-template-css-issues branch August 12, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaoK HaoK HaoK approved these changes

@javiercn javiercn javiercn approved these changes

Assignees

@SteveSandersonMS SteveSandersonMS

Labels

area-blazor Includes: Blazor, Razor Components

Projects

None yet

Milestone

6.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@SteveSandersonMS @javiercn @HaoK