Package r2rmap files in crossgened SFX symbol package #35288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
wtgodbe
approved these changes
Aug 12, 2021
Member
wtgodbe
left a comment
wtgodbe
left a comment
There was a problem hiding this comment.
Seems reasonable - this just changes the contents of the SharedFx symbol package to include .r2rmap instead of .map? Did you confirm (and check the SharedFx package itself too)?
Member
Author
|
Yup. Checked with an official build that all things are as expected and that the builds didn't break. After and before:
|
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crossgen2 now produces perfmap files that don't need the mvid in the name. This is work necessary to provide better profiling experience in different tools.
cc: @brianrob, @trylek, @tommcdon