Reduce allocations in Razor scenarios #35247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
sharwell
force-pushed
the
razor-allocs-3
branch
from
55a9637 to
6489955
Compare
Contributor
Author
|
😦 I'm tempted to use |
pranavkm
approved these changes
Aug 11, 2021
Contributor
pranavkm
left a comment
pranavkm
left a comment
There was a problem hiding this comment.
Very cool! Thanks for digging in to this.
src/Razor/Microsoft.AspNetCore.Razor.Language/src/BoundAttributeDescriptorComparer.cs
Outdated
Show resolved
Hide resolved
src/Razor/Microsoft.AspNetCore.Razor.Language/src/Legacy/CSharpCodeParser.cs
Outdated
Show resolved
Hide resolved
Contributor
|
@sharwell looks like more test baselines need to be updated |
sharwell
force-pushed
the
razor-allocs-3
branch
from
6489955 to
0d00280
Compare
sharwell
force-pushed
the
razor-allocs-3
branch
from
0d00280 to
6067de3
Compare
Member
|
@pranavkm - are you happy here? Should we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses some low hanging fruit in AB#1367582.
Each of the first three changes is in the range of 0.5-1.5% improvement. The final change is smaller, but still a trivial fix for 20+MiB allocations.