Skip to content

Update SDK to 6.0.100-rc.1.21410.3 #35229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wtgodbe merged 1 commit into from
Aug 16, 2021
Merged

Update SDK to 6.0.100-rc.1.21410.3 #35229

wtgodbe merged 1 commit into from
Aug 16, 2021

Conversation

@pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Aug 10, 2021

No description provided.

@pranavkm pranavkm requested review from a team and javiercn as code owners August 10, 2021 17:28
@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 10, 2021
@pranavkm
Copy link
Contributor Author

pranavkm commented Aug 10, 2021

Looks like this is still running in to dotnet/roslyn#55461. We'll have to wait for a new installer before the SDK can be updated.

@sebastienros
Copy link
Member

sebastienros commented Aug 11, 2021

This test fails:

https://github.com/dotnet/aspnetcore/blob/main/src/Razor/Microsoft.AspNetCore.Razor.Language/test/IntegrationTests/ComponentDirectiveIntegrationTest.cs#L95

with

 Microsoft.AspNetCore.Razor.Language.IntegrationTests.ComponentDirectiveIntegrationTest.SupportsInjectDirective
Microsoft.AspNetCore.Razor.Language.IntegrationTests.RazorIntegrationTestBase+CompilationFailedException : Compilation failed: \n/dir/subdir/Test/TestComponent.cshtml(3,120): error CS0103: The name 'MyService1' does not exist in the current context\n/dir/subdir/Test/TestComponent.cshtml(3,136): error CS0103: The name 'MyService2' does not exist in the current context\n(10,5): hidden CS8019: Unnecessary using directive.\n(7,5): hidden CS8019: Unnecessary using directive.\n(9,5): hidden CS8019: Unnecessary using directive.\n(8,5): hidden CS8019: Unnecessary using directive.\n(6,5): hidden CS8019: Unnecessary using directive.\n\n\nFile :\n// <auto-generated/>\n#pragma warning disable 1591\nnamespace Test\n{\n    #line hidden\n    using System;\n    using System.Collections.Generic;\n    using System.Linq;\n    using System.Threading.Tasks;\n    using Microsoft.AspNetCore.Components;\n    public partial class TestComponent : Microsoft.AspNetCore.Components.ComponentBase\n    {\n        #pragma warning disable 1998\n        protected override void BuildRenderTree(Microsoft.AspNetCore.Components.Rendering.RenderTreeBuilder __builder)\n        {\n            __builder.AddMarkupContent(0, \"MyService1\\nMicrosoft.AspNetCore.Razor.Language.IntegrationTests.ComponentDirectiveIntegrationTest.IMyService1@inject  MyService2\\nMicrosoft.AspNetCore.Razor.Language.IntegrationTests.ComponentDirectiveIntegrationTest.IMyService2@inject Hello from \");\n#nullable restore\n#line (3,119)-(3,129) 24 \"/dir/subdir/Test/TestComponent.cshtml\"\n__builder.AddContent(1, MyService1);\n\n#line default\n#line hidden\n#nullable disable\n            __builder.AddContent(2, \" and \");\n#nullable restore\n#line (3,135)-(3,145) 24 \"/dir/subdir/Test/TestComponent.cshtml\"\n__builder.AddContent(3, MyService2);\n\n#line default\n#line hidden\n#nullable disable\n        }\n        #pragma warning restore 1998\n    }\n}\n#pragma warning restore 1591\n\n
   at Microsoft.AspNetCore.Razor.Language.IntegrationTests.RazorIntegrationTestBase.CompileToAssembly(CompileToCSharpResult cSharpResult, Boolean throwOnFailure) in /_/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common/Language/IntegrationTests/RazorIntegrationTestBase.cs:line 305
   at Microsoft.AspNetCore.Razor.Language.IntegrationTests.RazorIntegrationTestBase.CompileToAssembly(String cshtmlRelativePath, String cshtmlContent) in /_/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common/Language/IntegrationTests/RazorIntegrationTestBase.cs:line 281
   at Microsoft.AspNetCore.Razor.Language.IntegrationTests.RazorIntegrationTestBase.CompileToComponent(String cshtmlSource) in /_/src/Razor/test/Microsoft.AspNetCore.Razor.Test.Common/Language/IntegrationTests/RazorIntegrationTestBase.cs:line 331
   at Microsoft.AspNetCore.Razor.Language.IntegrationTests.ComponentDirectiveIntegrationTest.SupportsInjectDirective() in /_/src/Razor/Microsoft.AspNetCore.Razor.Language/test/IntegrationTests/ComponentDirectiveIntegrationTest.cs:line 98

There are other tests failing but I believe they have the same root cause. @pranavkm can you take a quick look? If you give me some guidance I can apply the changes for you.

@wtgodbe
Copy link
Member

wtgodbe commented Aug 13, 2021

@pranavkm what are the non-SDK changes for?

@pranavkm
Copy link
Contributor Author

pranavkm commented Aug 13, 2021

@pranavkm what are the non-SDK changes for?

Trimmer changes and fixing logging analyzer warnings.

@wtgodbe
Copy link
Member

wtgodbe commented Aug 13, 2021

Well now we're very broken:

/Users/runner/work/1/s/src/Components/Components/src/NavigationManagerExtensions.cs(47,38): error CS0246: The type or namespace name 'DateTime' could not be found (are you missing a using directive or an assembly reference?) [/Users/runner/work/1/s/src/Components/Components/src/Microsoft.AspNetCore.Components.csproj]

Did these recently move? Looking

@pranavkm
Copy link
Contributor Author

pranavkm commented Aug 13, 2021

These files probably expect the implicit usings which were removed. For now, adding the usings back or adding ImplicitUsings=enable to the root Directory.Build.props would be the way to go.

@wtgodbe
Copy link
Member

wtgodbe commented Aug 13, 2021

Too much onion peeling, I'm just gonna enable implicit usings.

pranavkm
pranavkm commented Aug 13, 2021
View reviewed changes
@pranavkm pranavkm requested a review from halter73 as a code owner August 14, 2021 19:43
@pranavkm pranavkm force-pushed the prkrishn/update-sdk branch from 517302e to 7fa2274 Compare August 14, 2021 19:50
@pranavkm pranavkm force-pushed the prkrishn/update-sdk branch from 8c223e1 to d4420a2 Compare August 14, 2021 21:14
@wtgodbe wtgodbe merged commit f2c3abc into main Aug 16, 2021
@wtgodbe wtgodbe deleted the prkrishn/update-sdk branch August 16, 2021 16:16
@ghost ghost added this to the 6.0-rc1 milestone Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@javiercn javiercn Awaiting requested review from javiercn

@Pilchie Pilchie Awaiting requested review from Pilchie

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Milestone

6.0-rc1

Development

Successfully merging this pull request may close these issues.

5 participants

@pranavkm @sebastienros @wtgodbe @Pilchie