Reduce some allocations in Razor #35208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Avoids boxing in HashCodeCombiner * Avoids dictionary enumerator boxing in BoundAttributeDescriptorComparer.GetHashCode Based on https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1366879?src=WorkItemMention&src-action=artifact_link
pranavkm
commented
Aug 10, 2021
src/Razor/Microsoft.AspNetCore.Razor.Language/src/BoundAttributeDescriptorComparer.cs
Outdated
Show resolved
Hide resolved
pranavkm
commented
Aug 12, 2021
src/Razor/Microsoft.AspNetCore.Razor.Language/src/BoundAttributeDescriptorComparer.cs
Outdated
Show resolved
Hide resolved
…teDescriptorComparer.cs
sharwell
approved these changes
Aug 12, 2021
Pilchie
approved these changes
Aug 12, 2021
| } | ||
|
|
||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
| public void Add(IEnumerable e) |
Member
There was a problem hiding this comment.
We don't care about this? Presumably it's just calling the generic version now?
Contributor
Author
There was a problem hiding this comment.
I didn't see any uses for this and it seemed messier to add a generic version. Regardless, most of our codebase is using System.HashCode and Razor is an outlier due to it targeting ns2.0.
Contributor
There was a problem hiding this comment.
Did you see any uses of this before the introduction of the generic form? Derived types would prefer to call the generic form than cast to IEnumerable.
Contributor
There was a problem hiding this comment.
I just checked and I don't see any references prior to this PR.
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1366879?src=WorkItemMention&src-action=artifact_link