Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 9, 2021

Bumps src/submodules/googletest from 2d924d7 to aefb454.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [src/submodules/googletest](https://github.com/google/googletest) from `2d924d7` to `aefb454`.
- [Release notes](https://github.com/google/googletest/releases)
- [Commits](google/googletest@2d924d7...aefb454)

---
updated-dependencies:
- dependency-name: src/submodules/googletest
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from Pilchie as a code owner August 9, 2021 12:05
@dependabot dependabot bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 9, 2021
@wtgodbe
Copy link
Member

wtgodbe commented Aug 9, 2021

@JamesNK GOAWAY_GracefulServerShutdown_SendsGoAway is failing consistently here:

public async Task GOAWAY_GracefulServerShutdown_SendsGoAway(int connectionRequests, int expectedStreamId)

Can't imagine it's related - should Http3ConnectionTests be quarantined too? CC @Tratcher

@Tratcher
Copy link
Member

Tratcher commented Aug 9, 2021

Can't imagine it's related - should Http3ConnectionTests be quarantined too?

Not all of them, but anything that acts flaky.

@JamesNK
Copy link
Member

JamesNK commented Aug 9, 2021

I think I fixed the flakiness in that test with this change that I've just merged: https://github.com/dotnet/aspnetcore/pull/35168/files#diff-e5a99fa9cfdb2434b0f39373396b4a9d27f2d9b00326c51d7f430a52f6836691R95

If you want, go ahead and quarantine just in case, but mark the issue as test-fixed right away 😄

@wtgodbe
Copy link
Member

wtgodbe commented Aug 9, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@wtgodbe
Copy link
Member

wtgodbe commented Aug 9, 2021

@wtgodbe wtgodbe merged commit fa81ecc into main Aug 9, 2021
@wtgodbe wtgodbe deleted the dependabot/submodules/src/submodules/googletest-aefb454 branch August 9, 2021 23:30
@ghost ghost added this to the 6.0-rc1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants