HTTP/3: Only add alt-svc header if environment supports QUIC #35141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
BrennanConroy,
Tratcher and
halter73
as code owners
Tratcher
approved these changes
Aug 7, 2021
| else if (hasHttp3) | ||
| { | ||
| throw new InvalidOperationException("HTTP/3 requires https."); | ||
| throw new InvalidOperationException("HTTP/3 requires HTTPS."); |
Member
There was a problem hiding this comment.
? https is only defined as a url scheme and always uses lower case.
Member
Author
There was a problem hiding this comment.
But it is referred to in descriptions as upper case for its acryonm.
e.g. https://en.wikipedia.org/wiki/HTTPS
ghost
added this to the
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alt-svc was being added even if server didn't support QUIC.
Check for HttpProtocols.Http3 and server support.