Skip to content

Support struct FromBody parameters in minimal actions #35124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
halter73 merged 1 commit into from
Aug 9, 2021
Merged

Support struct FromBody parameters in minimal actions #35124

halter73 merged 1 commit into from
Aug 9, 2021

Conversation

@halter73
Copy link
Member

@halter73 halter73 commented Aug 6, 2021 •
edited
Loading

This makes taking a struct as a "[FromBody]" parameter work rather than throw an exception like System.InvalidOperationException: The binary operator Equal is not defined for the types 'Contact' and 'System.Object'. Ex.

var app = WebApplication.Create(args);

app.MapPost("/api/contact", (Contact dto) => $"{dto.pcfCode} {dto.email}");

app.Run();

record struct Contact(string pcfCode, string email);

Fixes #34842

@halter73 halter73 added feature-minimal-actions Controller-like actions for endpoint routing old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels labels Aug 6, 2021
@ghost ghost added the area-runtime label Aug 6, 2021
@davidfowl
Copy link
Member

davidfowl commented Aug 7, 2021

The PR description leaves much to be desired. I can't really tell where the fix is but I believe it works 😄

halter73
halter73 commented Aug 9, 2021
View reviewed changes
src/Http/Http.Extensions/src/RequestDelegateFactory.cs
Expression.Assign(argument, convertedBodyValue),
Expression.IfThen(
Expression.Equal(argument, Expression.Constant(null)),
Expression.Equal(BodyValueExpr, Expression.Constant(null)),
Copy link
Member Author

@halter73 halter73 Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fix. We don't cast from object to the struct type before checking bodyValue == null.

@halter73 halter73 merged commit 0a4f4ab into main Aug 9, 2021
@halter73 halter73 deleted the halter73/34842 branch August 9, 2021 19:39
@ghost ghost added this to the 6.0-rc1 milestone Aug 9, 2021
@amcasey amcasey added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidfowl davidfowl davidfowl approved these changes

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees

No one assigned

Labels

area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-minimal-actions Controller-like actions for endpoint routing old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels

Projects

None yet

Milestone

6.0-rc1

Development

Successfully merging this pull request may close these issues.

Minimal APIs: Structs broken with parameter binding

4 participants

@halter73 @davidfowl @amcasey