Skip to content

Conversation

@davidfowl
Copy link
Member

  • When using the deferred host builder, we set the application name via args so since the default name is the entry assembly. When hosted in tests, this will be the testhost instead of the application assembly name. This changes the default when using the WebApplicationFactory.
  • Added a test

Follow up from #35063

cc @martincostello

- When using the deferred host builder, we set the application name via args so since the default name is the entry assembly. When hosted in tests, this will be the testhost instead of the application assembly name. This changes the default when using the WebApplicationFactory.
- Added a test
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Aug 6, 2021
@davidfowl davidfowl requested a review from halter73 August 6, 2021 11:10
@davidfowl davidfowl enabled auto-merge (squash) August 6, 2021 11:12
@martincostello
Copy link
Member

Nice catch - I'd not hit this one yet as I've been waiting on RC1 to ship for the WebApplicationFactory fixes for my other repos before trying out the new minimal hosting on them.

I'll try out one of them in a branch with the latest daily installer once this change gets there and see if there's anything else lurking.

@davidfowl davidfowl merged commit 0c14ece into main Aug 6, 2021
@davidfowl davidfowl deleted the davidfowl/fix-assembly-name-testhost branch August 6, 2021 13:34
@ghost ghost added this to the 6.0-rc1 milestone Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants