Make sure route binding isn't case sensitive #35090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For error handling cases, we were doing a case sensitive match against route parameters instead of a case insensitive one. - Added tests
davidfowl
requested review from
BrennanConroy,
Tratcher and
javiercn
as code owners
ghost
added
the
davidfowl
added
old-area-web-frameworks-do-not-use
pranavkm
reviewed
Aug 6, 2021
| if (parameterCustomAttributes.OfType<IFromRouteMetadata>().FirstOrDefault() is { } routeAttribute) | ||
| { | ||
| if (factoryContext.RouteParameters is { } routeParams && !routeParams.Contains(parameter.Name)) | ||
| if (factoryContext.RouteParameters is { } routeParams && !routeParams.Contains(parameter.Name, StringComparer.OrdinalIgnoreCase)) |
Contributor
There was a problem hiding this comment.
Isn't this using Linq? Can we turn this in to HashSet instead? or write a bespoke iterator? The Linq one will result in allocations: https://github.com/dotnet/runtime/blob/main/src/libraries/System.Linq/src/System/Linq/Contains.cs#L33
Member
Author
There was a problem hiding this comment.
I think we should do that in another PR and did all the things. But I agree with you. There's too much LINQ usage here at startup
pranavkm
approved these changes
Aug 6, 2021
Member
Author
|
We should file another item to measure and fix the low hanging startup performance fruit here |
amcasey
added
the
area-minimal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35087