Guard against null BrowserManager #35079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
approved these changes
Aug 6, 2021
Member
Tratcher
left a comment
Tratcher
left a comment
There was a problem hiding this comment.
BrowserManager is only null if CreateAsync failed or was never called. Does that mean this null ref is masking a more serious issue?
Member
Author
|
I'll noodle around some more, its possible there are setup/lifetime issues that are different since those are called from LoggedTest/IAsyncDisposable I think, maybe because its skipped on some browsers |
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for dispose null refs in https://dev.azure.com/dnceng/public/_test/analytics?definitionId=331&contextType=build for BlazorTemplateTests