Skip to content

Added overload of WebApplication.CreateBuilder #34972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidfowl merged 2 commits into from
Aug 4, 2021
Merged

Added overload of WebApplication.CreateBuilder #34972

davidfowl merged 2 commits into from
Aug 4, 2021

Conversation

@davidfowl
Copy link
Member

@davidfowl davidfowl commented Aug 3, 2021 •
edited
Loading

  • Added WebApplicationOptions to that allow configuring any host configuration that can't be specified after the call.
  • Added tests

Fixes #34837

PS: Seems like the public API analyzer is broken for me right now

cc @captainsafia

@davidfowl
Added overload of WebApplication.CreateBuilder
e7474ce 
- Added WebApplicationOptions to that allow configuring any host configuration that can't be specified after the call.
- Added tests
@davidfowl davidfowl requested a review from Tratcher as a code owner August 3, 2021 07:37
@ghost ghost added the area-runtime label Aug 3, 2021
@davidfowl davidfowl requested a review from halter73 August 3, 2021 07:37
@davidfowl davidfowl requested a review from captainsafia August 3, 2021 07:37
khellang
khellang reviewed Aug 3, 2021
View reviewed changes
captainsafia
captainsafia reviewed Aug 3, 2021
View reviewed changes
@captainsafia captainsafia added the api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews label Aug 3, 2021
@ghost
Copy link

ghost commented Aug 3, 2021

Thank you for your API proposal. I'm removing the api-ready-for-review label. API Proposals should be submitted for review through Issues based on this template.

@ghost ghost removed the api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews label Aug 3, 2021
@davidfowl davidfowl added the api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews label Aug 4, 2021
@ghost
Copy link

ghost commented Aug 4, 2021

Thank you for your API proposal. I'm removing the api-ready-for-review label. API Proposals should be submitted for review through Issues based on this template.

@ghost ghost removed the api-ready-for-review API is ready for formal API review - https://github.com/dotnet/apireviews label Aug 4, 2021
@davidfowl davidfowl merged commit 32144f3 into main Aug 4, 2021
@davidfowl davidfowl deleted the davidfowl/webapplicationoptions branch August 4, 2021 20:36
@ghost ghost added this to the 6.0-rc1 milestone Aug 4, 2021
@halter73 halter73 mentioned this pull request Sep 15, 2022
Merged
@amcasey amcasey added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@captainsafia captainsafia captainsafia left review comments

@Tratcher Tratcher Tratcher approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

+1 more reviewer

@khellang khellang khellang left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-minimal-hosting

Projects

None yet

Milestone

6.0-rc1

Development

Successfully merging this pull request may close these issues.

Support specifying host configuration via WebApplication.CreateBuilder

6 participants

@davidfowl @khellang @Tratcher @captainsafia @amcasey