Skip to content

Fix nullability in User property #34887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
captainsafia merged 1 commit into from
Jul 30, 2021
Merged

Fix nullability in User property #34887

captainsafia merged 1 commit into from
Jul 30, 2021

Conversation

@captainsafia
Copy link
Member

@captainsafia captainsafia commented Jul 30, 2021

Template tests are failing in CI because this property should be set as nullable when it isn't.

[xUnit.net 00:01:11.25]         | [28.154s] Templates.Test.BlazorServerTemplateTest Information: /private/tmp/helix/working/AA290943/p/dotnet-cli/sdk/6.0.100-rc.1.21376.4/MSBuild.dll -maxcpucount -property:Configuration=Release -restore -target:Publish -verbosity:m /bl ./AspNet.i11muovbsaj.csproj
[xUnit.net 00:01:11.25]         | [28.682s] Templates.Test.BlazorServerTemplateTest Information:   Determining projects to restore...
[xUnit.net 00:01:11.25]         | [29.289s] Templates.Test.BlazorServerTemplateTest Information:   Restored /private/tmp/helix/working/AA290943/w/B3AA0A2B/e/Templates/BaseFolder/AspNet.i11muovbsaj/AspNet.i11muovbsaj.csproj (in 357 ms).
[xUnit.net 00:01:11.25]         | [29.415s] Templates.Test.BlazorServerTemplateTest Information:   You are using a preview version of .NET. See: https://aka.ms/dotnet-core-preview
[xUnit.net 00:01:11.25]         | [30.392s] Templates.Test.BlazorServerTemplateTest Information: /private/tmp/helix/working/AA290943/w/B3AA0A2B/e/Templates/BaseFolder/AspNet.i11muovbsaj/Pages/ShowProfile.razor(31,10): error CS8618: Non-nullable field 'user' must contain a non-null value when exiting constructor. Consider declaring the field as nullable. [/private/tmp/helix/working/AA290943/w/B3AA0A2B/e/Templates/BaseFolder/AspNet.i11muovbsaj/AspNet.i11muovbsaj.csproj]
[xUnit.net 00:01:11.25]         | [30.426s] Templates.Test.BlazorServerTemplateTest Information: Process exited.
[xUnit.net 00:01:11.25]         | [30.427s] Templates.Test.BlazorServerTemplateTest Error: Test threw an exception.
[xUnit.net 00:01:11.25]         | Xunit.Sdk.TrueException: Project new blazorserver  --auth SingleOrg --calls-graph failed to publish. Exit code 1.
[xUnit.net 00:01:11.25]         | /private/tmp/helix/working/AA290943/p/dotnet-cli/dotnet publish  -c Release /bl \nStdErr: \nStdOut: Microsoft (R) Build Engine version 17.0.0-preview-21371-01+9e576281e for .NET
[xUnit.net 00:01:11.25]         | Copyright (C) Microsoft Corporation. All rights reserved.
[xUnit.net 00:01:11.25]         | /private/tmp/helix/working/AA290943/p/dotnet-cli/sdk/6.0.100-rc.1.21376.4/MSBuild.dll -maxcpucount -property:Configuration=Release -restore -target:Publish -verbosity:m /bl ./AspNet.i11muovbsaj.csproj
[xUnit.net 00:01:11.25]         |   Determining projects to restore...
[xUnit.net 00:01:11.25]         |   Restored /private/tmp/helix/working/AA290943/w/B3AA0A2B/e/Templates/BaseFolder/AspNet.i11muovbsaj/AspNet.i11muovbsaj.csproj (in 357 ms).
[xUnit.net 00:01:11.25]         |   You are using a preview version of .NET. See: https://aka.ms/dotnet-core-preview
[xUnit.net 00:01:11.25]         | /private/tmp/helix/working/AA290943/w/B3AA0A2B/e/Templates/BaseFolder/AspNet.i11muovbsaj/Pages/ShowProfile.razor(31,10): error CS8618: Non-nullable field 'user' must contain a non-null value when exiting constructor. Consider declaring the field as nullable. [/private/tmp/helix/working/AA290943/w/B3AA0A2B/e/Templates/BaseFolder/AspNet.i11muovbsaj/AspNet.i11muovbsaj.csproj]
[xUnit.net 00:01:11.25]         | Expected: True
[xUnit.net 00:01:11.25]         | Actual:   False
[xUnit.net 00:01:11.25]         |    at Xunit.Assert.True(Nullable`1 condition, String userMessage) in C:\Dev\xunit\xunit\src\xunit.assert\Asserts\BooleanAsserts.cs:line 95
[xUnit.net 00:01:11.25]         |    at Templates.Test.BlazorTemplateTest.CreateBuildPublishAsync(String projectName, String auth, String[] args, String targetFramework, Boolean serverProject, Boolean onlyCreate) in /_/src/ProjectTemplates/BlazorTemplates.Tests/BlazorTemplateTest.cs:line 114

@captainsafia captainsafia requested a review from a team as a code owner July 30, 2021 15:34
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 30, 2021
@captainsafia captainsafia enabled auto-merge (squash) July 30, 2021 15:48
@captainsafia
Copy link
Member Author

captainsafia commented Jul 30, 2021

Using my powers to merge despite failures since it is a flaky test that is already quarantined.

@captainsafia captainsafia disabled auto-merge July 30, 2021 17:31
@captainsafia captainsafia merged commit 9012227 into main Jul 30, 2021
@captainsafia captainsafia deleted the safia/fix-nullability branch July 30, 2021 17:31
@ghost ghost added this to the 6.0-rc1 milestone Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaoK HaoK HaoK approved these changes

+1 more reviewer

@pranavkm pranavkm pranavkm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Milestone

6.0-rc1

Development

Successfully merging this pull request may close these issues.

4 participants

@captainsafia @pranavkm @HaoK