Skip to content

Check that the event source is enabled before dumping config #34879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
captainsafia merged 1 commit into from
Jul 30, 2021
Merged

Check that the event source is enabled before dumping config #34879

captainsafia merged 1 commit into from
Jul 30, 2021

Conversation

@davidfowl
Copy link
Member

@davidfowl davidfowl commented Jul 30, 2021 •
edited
Loading

  • Make sure the event source is enabled before dumping configuration.
  • Change the level to log always

Follow up to #34680

@davidfowl
Check that the event source is enabled before dumping config
4b7dfac 
- Make sure the event source is enabled before dumping configuration.
- Change the level to log always
@ghost ghost added the area-runtime label Jul 30, 2021
noahfalk
noahfalk approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM : )

shirhatti
shirhatti reviewed Jul 30, 2021
View reviewed changes
src/Servers/Kestrel/Core/src/Internal/Infrastructure/KestrelEventSource.cs

[MethodImpl(MethodImplOptions.NoInlining)]
[Event(11, Level = EventLevel.Informational)]
[Event(11, Level = EventLevel.LogAlways)]
Copy link
Contributor

@shirhatti shirhatti Jul 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why LogAlways?

Copy link
Member Author

@davidfowl davidfowl Jul 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Payload is small enough to not cause any damage and you'll always get it once per attach

@davidfowl
Copy link
Member Author

davidfowl commented Jul 30, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 30, 2021

Azure Pipelines successfully started running 2 pipeline(s).

@davidfowl
Copy link
Member Author

davidfowl commented Jul 30, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 30, 2021

Azure Pipelines successfully started running 2 pipeline(s).

@captainsafia
Copy link
Member

captainsafia commented Jul 30, 2021

Using my admin privileges to merge. Builds on this PR have been failing due to unrelated flakiness with the Component tests. Merging to unblock.

@captainsafia captainsafia merged commit d9c9083 into main Jul 30, 2021
@captainsafia captainsafia deleted the davidfowl/check-enabled branch July 30, 2021 20:08
@ghost ghost added this to the 6.0-rc1 milestone Jul 30, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noahfalk noahfalk noahfalk approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@Tratcher Tratcher Awaiting requested review from Tratcher

+1 more reviewer

@shirhatti shirhatti shirhatti left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

6.0-rc1

Development

Successfully merging this pull request may close these issues.

6 participants

@davidfowl @captainsafia @shirhatti @noahfalk @amcasey