HTTP/3: End-to-end test of server streaming #34876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
BrennanConroy,
Tratcher and
halter73
as code owners
halter73
reviewed
Jul 30, 2021
| var buffer = new byte[clientBufferSize]; | ||
| var readCount = 0; | ||
|
|
||
| while ((readCount = await responseStream.ReadAsync(buffer).DefaultTimeout()) != -1) |
Member
There was a problem hiding this comment.
What does responseStream.ReadAsync() returning -1 mean? Should this be checking for 0 and failing if we reach the end of the Stream early?
Member
Author
There was a problem hiding this comment.
It means I made a mistake 😄
It is never a problem because the break on length always comes before the stream returns 0 (which is what was meant to be tested).
I've updated all the tests to use existing helper methods.
halter73
approved these changes
Jul 30, 2021
ghost
added this to the
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.