-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[blazor] Fix InvariantGlobalization startup without AOT #34804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
javiercn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@lewing could you do a once-over to make sure this is the right change? |
|
+1 |
I'm pretty sure my change to fix dotnet/runtime#49391 exposed this bug in how environment variables are handled in WASM. I think this was always broken, but because the error was being eaten, no one noticed. |
|
There is also dotnet/runtime#56667 |
|
There are E2E wasm tests, like https://github.com/dotnet/aspnetcore/blob/main/src/Components/test/E2ETest/Tests/WebAssemblyGlobalizationTest.cs . One for this case can be added there. |
This is about the timing of the call that sets up the environment. Blazor has its own startup code and does a lot in preRun which is too early for some things (it actually triggers emscripten assertions if you enable them). |
Is there a test that is already covering this, but was disabled? |
|
Hi @radical. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
The environment variables could be only set when the runtime is ready.
Fixes dotnet/runtime#55750