Fix reconnect count in messages #34773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
reviewed
Jul 28, 2021
|
|
||
| // we incremented then saw that the next reconnect delay was null, meaning reconnect attempts are exhausted, | ||
| // so decrement to have the correct number for logs and exceptions | ||
| previousReconnectAttempts--; |
Member
There was a problem hiding this comment.
Should wee just increment this at the start of the while (nextRetryDelay != null) so we don't have to decrement? Or maybe after the Task.Delay, since if it was canceled by shutdown or something we technically didn't attempt a reconnect.
Member
Author
There was a problem hiding this comment.
So I changed it to try that out, it required changing a couple other spots too. Take a quick look to make sure it's not obviously wrong, or if we prefer the first way.
halter73
approved these changes
Jul 28, 2021
halter73
reviewed
Jul 28, 2021
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34549