HTTP/3: Update generated transport features #34757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
BrennanConroy,
Tratcher and
halter73
as code owners
ghost
added
the
Tratcher
approved these changes
Jul 27, 2021
halter73
reviewed
Jul 27, 2021
| "IStreamDirectionFeature", | ||
| "IStreamIdFeature", | ||
| "IStreamAbortFeature", | ||
| "ITlsConnectionFeature" |
Member
There was a problem hiding this comment.
I wonder when it starts to make sense to generate different base classes for the Socket and Quic transports. This is still nowhere near HttpProtocol levels of features, so I suppose this is fine for now.
halter73
approved these changes
Jul 27, 2021
JamesNK
force-pushed
the
jamesnk/http3-quicstreamcontext-features
branch
from
8e25adc to
cec9035
Compare
JamesNK
force-pushed
the
jamesnk/http3-quicstreamcontext-features
branch
from
cec9035 to
f0b5443
Compare
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.