Fix StreamPool_MultipleStreamsInSequence_PooledStreamReused #34686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
BrennanConroy,
Tratcher and
halter73
as code owners
ghost
added
the
JamesNK
changed the title
halter73
reviewed
Jul 26, 2021
halter73
reviewed
Jul 26, 2021
| [Theory] | ||
| [InlineData(10)] | ||
| [InlineData(100)] | ||
| [InlineData(1000)] |
Member
There was a problem hiding this comment.
Are these numbers significant for any reason? Why does testing two requests as above not give us sufficient coverage? I know these are really fast, but how long does it take to complete 1000 requests in sequence?
Member
Author
There was a problem hiding this comment.
No significance. 1000 takes less than a second. I wanted a test that stresses pooling and makes thread-safety issues fail reliable.
halter73
approved these changes
Jul 26, 2021
JamesNK
changed the title
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34685