FileLoggerProcessor write to a new file on new instance or Fields change #34652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Tratcher
approved these changes
Jul 23, 2021
| _path = loggerOptions.LogDirectory; | ||
| } | ||
|
|
||
| _fileName = loggerOptions.FileName; |
Member
There was a problem hiding this comment.
If the file name changes should the file number reset, or be rescanned for?
Member
Author
There was a problem hiding this comment.
Yeah, I think so, that'd be a way for users to get around the 10,000 file a day limit if they wanted to. But it might be somewhat tricky - e.g. OnChange fires in the middle of execution of WriteMessagesAsync, causing the FileNumber to go back to zero. If this happens while we're scanning through some previous files to find out if they exist, it could cause us to suffix the first file with the new name with something nonzero. I'll file a follow-up issue for this one, for now I think it's fine if the numbering for the new file names pick up where the old ones left off.
halter73
reviewed
Jul 23, 2021
Member
Author
|
Updated for feedback |
BrennanConroy
approved these changes
Jul 28, 2021
halter73
approved these changes
Jul 28, 2021
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34595