Multiple root components start in parallel. #34634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
MackinnonBuck
commented
Jul 23, 2021
src/Components/WebAssembly/WebAssembly/src/Hosting/WebAssemblyHost.cs
Outdated
Show resolved
Hide resolved
There wasn't a way to make this comply with the DynamicallyAccessedMembers code analysis.
SteveSandersonMS
approved these changes
Jul 26, 2021
Member
SteveSandersonMS
left a comment
SteveSandersonMS
left a comment
There was a problem hiding this comment.
Looks great!
I'm not sure how practical it is to E2E test this. If you think there is a straightforward way then that would be cool, but if it involves adding a load of extra testing infrastructure then I'm not sure the tradeoff would be worth it.
Actually it might be much more reasonable to add unit tests though. I see we already have CircuitHostTest - that could probably be extended to cover this new behavior. What do you think?
pranavkm
reviewed
Jul 26, 2021
pranavkm
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple root components start in parallel.
Each root component is added and processed in parallel, rather than waiting for one to become quiescent before adding the next.
PR Description
Hosts now add each root component ignoring the task awaiting quiescence. Then, after all root components are added, the host awaits quiescence for all components.
Addresses #34306