Do not overwrite NoWarn in Mvc.Testing #34592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not overwrite the NoWarn property, and instead add to it.
Do not overwrite the NoWarn property, and instead add to it.
Do not overwrite the NoWarn property, and instead add to it.
martincostello
requested review from
Pilchie,
javiercn and
pranavkm
as code owners
ghost
added
the
community-contribution
pranavkm
reviewed
Jul 21, 2021
| <IsPackable>true</IsPackable> | ||
| <!-- We're disable NU5100 explicitly bundling assemblies as tasks so they are not referenced when consumed. --> | ||
| <NoWarn>NU5100</NoWarn> | ||
| <NoWarn>$(NoWarn);NU5100</NoWarn> |
Contributor
There was a problem hiding this comment.
I realize this isn't caused by you, but I think we might be able avoid this warning by packing the binaries in the build directory rather than in a task folder. Would you be interested in taking a stab at that?
Member
Author
There was a problem hiding this comment.
Sure.
Do you have a rough link to some prior art elsewhere in the repo to get a gist of the changes needed?
Happy for me to do that separately rather than roll it into this?
pranavkm
approved these changes
Jul 21, 2021
mkArtakMSFT
added
the
area-mvc
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title
Do not overwrite the NoWarn property, and instead add to it.
PR Description
I'm having analyzer issues locally with VS 2022 preview 2 with RC1 dailies causing builds to fail, so I locally added
<NoWarn>$(NoWarn);AD0001</NoWarn>toDirectory.Build.propsto work around it.This surfaced that the ApiAuthorization.IdentityServer, Mvc.Testing, and Shared.Tests projects were overwriting the whole
NoWarnproperty instead of appending to it, so this PR fixes that.