Make sync and async disposal of Renderer behave the same #34511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pranavkm
commented
Jul 19, 2021
| /// </summary> | ||
| /// <param name="disposing"><see langword="true"/> if this method is being invoked by <see cref="IDisposable.Dispose"/>, otherwise <see langword="false"/>.</param> | ||
| protected virtual void Dispose(bool disposing) | ||
| protected virtual void Dispose(bool disposing) => DisposeAsync().AsTask().GetAwaiter().GetResult(); |
Contributor
Author
There was a problem hiding this comment.
@javiercn you have the most context here - do you remember why Dispose doesn't implement by calling DisposeAsync and blocking?
Member
There was a problem hiding this comment.
Likely because that was virtual and would break consumers
Member
There was a problem hiding this comment.
Blocking is impossible and throws on WebAssembly. I know you don't normally dispose a renderer on WebAssembly but nothing stops you.
SteveSandersonMS
approved these changes
Jul 20, 2021
Member
SteveSandersonMS
left a comment
SteveSandersonMS
left a comment
There was a problem hiding this comment.
Seems this doesn't change the sync-vs-async disposal thing any more, so if it's just moving the HotReloadManager.OnDeltaApplied -= ... instruction, looks very straightforwards :)
Contributor
Author
|
Yeah, the virtual bit is an important detail we wouldn't to needlessly change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.