Skip to content

Add timestamp to ANCM logs #34437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BrennanConroy merged 10 commits into from
Jul 30, 2021
Merged

Add timestamp to ANCM logs #34437

BrennanConroy merged 10 commits into from
Jul 30, 2021

Conversation

@BrennanConroy
Copy link
Member

@BrennanConroy BrennanConroy commented Jul 16, 2021 •
edited
Loading

Copied from https://github.com/aspnet/SignalR-Client-Cpp/blob/main/src/signalrclient/logger.cpp

Fixes #29161

Example logs:

[2021-07-28T19:23:44.076Z, PID: 11020] [aspnetcorev2.dll] Initializing logs for 'C:\<path>\aspnetcorev2.dll'. Process Id: 11020. File Version: 16.0.21209.0. Description: IIS ASP.NET Core Module V2. Commit: 96475a2acdf50d7599ba8e96583fa73efbe27912.
[2021-07-28T19:23:44.079Z, PID: 11020] [aspnetcorev2.dll] Resolving hostfxr parameters for application: '.\InProcessWebSite.exe' arguments: '' path: 'C:\Temp\e86ac4e9ced24bb6bacf1a9415e70753\'
[2021-07-28T19:23:44.080Z, PID: 11020] [aspnetcorev2.dll] Known dotnet.exe location: ''

jkotalik
jkotalik approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@jkotalik jkotalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BrennanConroy
Copy link
Member Author

BrennanConroy commented Jul 22, 2021

Haha, maybe I should ping you about this Justin, I'm a bit confused about all the different logs 😄

@jkotalik
Copy link
Contributor

jkotalik commented Jul 23, 2021

Yeah put some time on my calendar 😎

HaoK
HaoK reviewed Jul 28, 2021
View reviewed changes
BrennanConroy
BrennanConroy commented Jul 29, 2021
View reviewed changes
src/Servers/IIS/AspNetCoreModuleV2/CommonLib/debugutil.cpp
PrintDebugHeader()
{
// Major, minor are stored in dwFileVersionMS field and patch, build in dwFileVersionLS field as pair of 32 bit numbers
LOG_INFOF(L"Initializing logs for '%ls'. %ls. %ls.",
Copy link
Member Author

@BrennanConroy BrennanConroy Jul 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the . because GetProcessIdString() already returns the . and my log OCD wasn't happy with "Process ID: 1029.."

@BrennanConroy BrennanConroy marked this pull request as ready for review July 29, 2021 20:05
shirhatti
shirhatti approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@shirhatti shirhatti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only approving the sample output and not attempting to review C++ 😅

@BrennanConroy BrennanConroy merged commit 63a4353 into main Jul 30, 2021
@BrennanConroy BrennanConroy deleted the brecon/ancmtime branch July 30, 2021 22:02
@ghost ghost added this to the 6.0-rc1 milestone Jul 30, 2021
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaoK HaoK HaoK left review comments

@halter73 halter73 halter73 approved these changes

@adityamandaleeka adityamandaleeka adityamandaleeka approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

+2 more reviewers

@shirhatti shirhatti shirhatti approved these changes

@jkotalik jkotalik jkotalik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-iis Includes: IIS, ANCM

Projects

None yet

Milestone

6.0-rc1

Development

Successfully merging this pull request may close these issues.

ANCM debug log should include PIDs and timestamps

8 participants

@BrennanConroy @jkotalik @halter73 @adityamandaleeka @shirhatti @HaoK @amcasey