Use Environment.TickCount64 instead of UtcNow in SignalR #34382
Merged
+56
−97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Jul 15, 2021
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionContext.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Jul 15, 2021
halter73
reviewed
Jul 15, 2021
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionDispatcher.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
Bump |
halter73
reviewed
Jul 27, 2021
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionManager.cs
Outdated
Show resolved
Hide resolved
halter73
approved these changes
Jul 27, 2021
halter73
reviewed
Jul 27, 2021
| /// <summary> | ||
| /// Retrieves the current UTC system time. | ||
| /// </summary> | ||
| public DateTimeOffset UtcNow => DateTimeOffset.UtcNow; |
Member
There was a problem hiding this comment.
Does this mean there were no tests for AuthenticationExpiration?
Member
Author
There was a problem hiding this comment.
There are, but they aren't using the clock abstraction.
halter73
reviewed
Jul 27, 2021
src/SignalR/server/SignalR/test/HubConnectionHandlerTestUtils/MockSystemClock.cs
Outdated
Show resolved
Hide resolved
BrennanConroy
commented
Jul 27, 2021
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionManager.cs
Show resolved
Hide resolved
Co-authored-by: Stephen Halter <[email protected]>
BrennanConroy
commented
Jul 27, 2021
src/SignalR/server/SignalR/test/HubConnectionHandlerTestUtils/MockSystemClock.cs
Outdated
Show resolved
Hide resolved
…MockSystemClock.cs
ghost
added this to the
Member
|
Did we file the issue for kestrel? |
Member
Author
|
Issue is still open for doing the same in Kestrel #13628 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13628
Kestrel is proving to be more difficult than I thought it would, so not including it here.