Skip to content

Conversation

@halter73
Copy link
Member

  • Apply host config before app config
  • Avoid duplicate config sources
  • Reduce I/O reloading config while bootstrapping
  • Reduce duplicate services

Before this change, logging configuration like the following would not be respected if it was in an environment-specific config like appsettings.Development.json (as opposed to appsettings.json).

{
  "Logging": {
    "LogLevel": {
      "Default": "Information",
      "Microsoft": "Debug",
      "Microsoft.Hosting.Lifetime": "Information"
    }
  }
}

This also removes a ton of duplicate and conflicting configuration sources as noted previous closed PR: #32822

Loading less sources and not automatically reloading sources every time one is added during the "bootstrapping" of the default configuration results in far fewer file system checks leading to better startup performance.

Fixes #32383
Fixes #32432

This is the same as #32926 but targets main.

- Apply host config before app config
- Avoid duplicate config sources
- Reduce I/O reloading config while bootstrapping
- Reduce duplicate services
Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you redesigned the entire thing? 😆

@halter73 halter73 enabled auto-merge (squash) June 7, 2021 23:22
@halter73 halter73 added this to the 6.0-preview6 milestone Jun 7, 2021
@halter73 halter73 merged commit 7713086 into main Jun 8, 2021
@halter73 halter73 deleted the halter73/32383 branch June 8, 2021 00:35
@davidfowl
Copy link
Member

@halter73 can you confirm this fixes #33335?

@amcasey amcasey added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-runtime labels Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-minimal-hosting

Projects

None yet

5 participants