Skip to content

Don't call HttpCloseUrlGroup if you didn't create it #28336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shirhatti merged 2 commits into from
Dec 4, 2020
Merged

Don't call HttpCloseUrlGroup if you didn't create it #28336

shirhatti merged 2 commits into from
Dec 4, 2020

Conversation

@shirhatti
Copy link
Contributor

@shirhatti shirhatti commented Dec 2, 2020 •
edited
Loading

Added a _created bool to track whether we created or attached to the UrlGroup

@ghost ghost added the area-servers label Dec 2, 2020
@shirhatti
Copy link
Contributor Author

shirhatti commented Dec 2, 2020

Not sure how to test this 😕 HttpCloseUrlGroup doesn't fail unless called from a different process

@shirhatti shirhatti linked an issue Dec 2, 2020 that may be closed by this pull request
HttpSysRequestDelegationFeature - DelegationRule.Dispose() - Call to HttpCloseUrlGroup Fails with result ERROR_INVALID_PARAMETER #26989
Closed
@shirhatti shirhatti mentioned this pull request Dec 3, 2020
Merged
@Tratcher
Copy link
Member

Tratcher commented Dec 3, 2020

This seems fine. If we really wanted to test it we could spin up a separate process for the delegator. We have tests like that in Hosting.

@shirhatti shirhatti merged commit 5c0daf9 into master Dec 4, 2020
@shirhatti shirhatti deleted the shirhatti/dontcloseurlgroup branch December 4, 2020 00:47
@shirhatti shirhatti added this to the 6.0-preview1 milestone Dec 4, 2020
This was referenced Dec 4, 2020
Closed
Merged
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Tratcher approved these changes

@halter73 halter73 Awaiting requested review from halter73

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

6.0-preview1

Development

Successfully merging this pull request may close these issues.

HttpSysRequestDelegationFeature - DelegationRule.Dispose() - Call to HttpCloseUrlGroup Fails with result ERROR_INVALID_PARAMETER

4 participants

@shirhatti @Tratcher @amcasey