Http2MessageBody.TryRead TryStart/TryStop #13464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benaadams
requested review from
Tratcher,
analogrelay,
halter73 and
jkotalik
as code owners
Contributor
halter73
added
the
ask-mode
Member
|
I added the ask mode template. If I need any more changes @benaadams, I can open up a new branch/PR. Sorry for the hassle! |
Member
|
This is approved by tactics, assuming the helix failures are un-related. |
Member
|
Thanks @benaadams! |
halter73
approved these changes
Aug 27, 2019
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13305 targeting release/3.0
/cc @halter73
Ask mode template
Description
If an app uses the new PipeReader.TryRead API on an HTTP/2 request body, request rate calculations will be done incorrectly.
Customer Impact
This can potentially lead to issues where a client that has met the configured minimum request body rate would still see its request aborted.
Regression?
Technically no, since this is a new API, but this would be a regression for apps that switched from using Stream.ReadAsync to using PipeReader.TryRead to read a request body.
Risk
Low, since this change only impacts apps that read a request body using PipeReader.TryRead.