Move AfterBuild Target to more accurate project #13281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
force-pushed
the
brecon/targets
branch
from
eb59177 to
cb72a24
Compare
BrennanConroy
changed the base branch from
release/3.0-preview9
to
release/3.0
JunTaoLuo
approved these changes
Aug 22, 2019
src/SignalR/clients/ts/FunctionalTests/SignalR.Npm.FunctionalTests.npmproj
Show resolved
Hide resolved
BrennanConroy
added
the
tell-mode
BrennanConroy
requested review from
analogrelay,
halter73 and
mikaelm12
as code owners
|
This comment was made automatically. If there is a problem contact [email protected]. I've triaged the above build. I've created/commented on the following issue(s) |
Member
Author
|
Ok, I'm merging this. @mikaelm12 @halter73 if you have any issues with the changes let me know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/aspnet/AspNetCore-Internal/issues/3002
FYI SignalR team, this change does add a small quirk to running the JS Functional tests manually.
You will need to build the "SignalR.Npm.FunctionalTests.npmproj" first. From the command line you can do that via
dotnet msbuild SignalR.Npm.FunctionalTests.npmproj. And whenever changes are made to the client you'll need to rebuild it.This is only for manual test runs. npm test or yarn test should still be fine.