Fix form pipe parser #12749
Merged
Fix form pipe parser #12749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Perf numbers? |
davidfowl
reviewed
Jul 30, 2019
davidfowl
reviewed
Jul 30, 2019
davidfowl
reviewed
Jul 31, 2019
jkotalik
reviewed
Jul 31, 2019
halter73
reviewed
Jul 31, 2019
Member
Author
|
Before:
After:
LGTM |
jkotalik
reviewed
Jul 31, 2019
...ities/perf/Microsoft.AspNetCore.WebUtilities.Performance/FormPipeReaderInternalsBenchmark.cs
Show resolved
Hide resolved
Contributor
|
|
Contributor
|
If we're taking this for Ask-Mode, needs the template and label. Otherwise it needs to be on |
Tratcher
added
the
ask-mode
Member
Author
|
@anurse added the template. Suggested for preview9 because we've had direct customer reports of the regression impacting their apps. |
Contributor
|
Sounds good. Meets the bar IMO, we'll confirm tomorrow. |
Member
|
Tactics approved |
ghost
deleted the
This was referenced Aug 23, 2019
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#12381
Issue 1) Keys without values were being merged "key1&key2=value2"
Issue 2) Keys without values at the end of a form being dropped (2.2) or throwing (3.0) "key1=value1&key2".
Customer Impact
Externally posted forms were being mis-parsed in some situations.
Regression?
Yes, in 2.2 un-parsed trailing data would be discarded, but in 3.0 it throws.
Risk
Low, we have good unit test coverage here.
Old algorithm: Look for "=", then "&".
New algorithm: Look for "&", then see if it has an optional "="