Skip to content

Resolve some reactredux warnings #11874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ryanbrandenburg wants to merge 1 commit into from
Closed

Resolve some reactredux warnings #11874

ryanbrandenburg wants to merge 1 commit into from

Conversation

@ryanbrandenburg
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg commented Jul 3, 2019

This seems to have started causing failures when we updated our typescript version. It was missed because those tests were marked as flaky.

@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jul 3, 2019
@ryanbrandenburg ryanbrandenburg mentioned this pull request Jul 3, 2019
Merged
@ryanbrandenburg
Copy link
Contributor Author

ryanbrandenburg commented Jul 3, 2019

Closing in favor of #11784 which needed the change anyway.

@ryanbrandenburg ryanbrandenburg deleted the rybrande/ReduxWarnings branch July 3, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryanbrandenburg @Eilon