gRPC template fixes #11775
Merged
gRPC template fixes #11775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JunTaoLuo
commented
Jul 1, 2019
JunTaoLuo
commented
- Update the version of gRPC packages in our templates to what will be shipped by the gRPC team. This change is expected since the gRPC team produces the package after our branching, and this is the only way we ship with external packages in lock step.
- Update the port used by the gRPC template from https://localhost:50051 to the default for AspNetCore templates https://localhost:5001. This was missed in my original PR: gRPC template updates #11473 (comment)
- Enforce HTTP2 only on gRPC templates. This enforcement was removed in gRPC template updates #11473 by accident.
Contributor
|
@JunTaoLuo looks like this is early: |
Member
|
0.1.22-pre2 should be added to NuGet tonight. |
Contributor
Author
|
Yea these changes are pre-emptive. However, I still don't see 0.1.22.pre2 yet on nuget. Will speak with the gRPC team today. |
Contributor
Author
|
Yea I've been rerunning the template tests which failed due to flakiness. Waiting for a green build. |
JamesNK
approved these changes
Jul 2, 2019
shirhatti
approved these changes
Jul 2, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.