Skip to content

gRPC template updates #11473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JunTaoLuo merged 3 commits into from
Jun 27, 2019
Merged

gRPC template updates #11473

JunTaoLuo merged 3 commits into from
Jun 27, 2019

Conversation

@JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Jun 23, 2019 •
edited
Loading

@Eilon Eilon added the area-grpc Includes: GRPC wire-up, templates label Jun 23, 2019
@JunTaoLuo JunTaoLuo marked this pull request as ready for review June 25, 2019 04:47
@JunTaoLuo JunTaoLuo force-pushed the johluo/grpc-templates branch from 6712d8e to e64daf3 Compare June 25, 2019 04:47
@JunTaoLuo JunTaoLuo requested review from JamesNK and shirhatti June 25, 2019 04:47
@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Jun 25, 2019

I'm able to test the project template in VS and command line. I've tested the item template on the command line but I don't think there's a good way to test it in vs cc @BillHiebert @phenning ?

@shirhatti shirhatti closed this Jun 25, 2019
@shirhatti shirhatti reopened this Jun 25, 2019
@shirhatti
Copy link
Contributor

shirhatti commented Jun 25, 2019

@JunTaoLuo Can you confirm this blows up on a Mac as expected by #11061?

@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Jun 25, 2019

Error at startup:

warn: Microsoft.AspNetCore.Server.Kestrel[0]
      Unable to bind to https://localhost:5001 on the IPv4 loopback interface: 'HTTP/2 over TLS is not supported on OSX due to missing ALPN support.'.
warn: Microsoft.AspNetCore.Server.Kestrel[0]
      Unable to bind to https://localhost:5001 on the IPv6 loopback interface: 'HTTP/2 over TLS is not supported on OSX due to missing ALPN support.'.
crit: Microsoft.AspNetCore.Server.Kestrel[0]
      Unable to start Kestrel.
System.IO.IOException: Failed to bind to address https://localhost:5001.
 ---> System.AggregateException: One or more errors occurred. (HTTP/2 over TLS is not supported on OSX due to missing ALPN support.) (HTTP/2 over TLS is not supported on OSX due to missing ALPN support.)
 ---> System.NotSupportedException: HTTP/2 over TLS is not supported on OSX due to missing ALPN support.
   at Microsoft.AspNetCore.Server.Kestrel.Https.Internal.HttpsConnectionMiddleware..ctor(ConnectionDelegate next, HttpsConnectionAdapterOptions options, ILoggerFactory loggerFactory)
   at Microsoft.AspNetCore.Hosting.ListenOptionsHttpsExtensions.<>c__DisplayClass12_0.<UseHttps>b__0(ConnectionDelegate next)
   at Microsoft.AspNetCore.Server.Kestrel.Core.ListenOptions.Build()
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer.<>c__DisplayClass21_0`1.<<StartAsync>g__OnBind|0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context)
   at Microsoft.AspNetCore.Server.Kestrel.Core.LocalhostListenOptions.BindAsync(AddressBindContext context)
   --- End of inner exception stack trace ---
 ---> (Inner Exception #1) System.NotSupportedException: HTTP/2 over TLS is not supported on OSX due to missing ALPN support.
   at Microsoft.AspNetCore.Server.Kestrel.Https.Internal.HttpsConnectionMiddleware..ctor(ConnectionDelegate next, HttpsConnectionAdapterOptions options, ILoggerFactory loggerFactory)
   at Microsoft.AspNetCore.Hosting.ListenOptionsHttpsExtensions.<>c__DisplayClass12_0.<UseHttps>b__0(ConnectionDelegate next)
   at Microsoft.AspNetCore.Server.Kestrel.Core.ListenOptions.Build()
   at Microsoft.AspNetCore.Server.Kestrel.Core.KestrelServer.<>c__DisplayClass21_0`1.<<StartAsync>g__OnBind|0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.AddressBinder.BindEndpointAsync(ListenOptions endpoint, AddressBindContext context)
   at Microsoft.AspNetCore.Server.Kestrel.Core.LocalhostListenOptions.BindAsync(AddressBindContext context)<---

@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Jun 25, 2019

😮 We still call it OSX instead of macOS?

@shirhatti
Copy link
Contributor

shirhatti commented Jun 25, 2019

We still call it OSX instead of macOS?

Looks like we aren't consistent. We're all over the place on this 😞

@shirhatti
Copy link
Contributor

shirhatti commented Jun 25, 2019

@DamianEdwards FYI. Based on our conversation earlier, the gRPC templates will use HTTPS by default. It will blow up on macOS on Startup where there is no server-side ALPN.

JamesNK
JamesNK approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to double check with Jan about why gRPC samples use ports in 5005x.

Also need to update the linked tutorial to add HTTPS, and change the port used in it. Shouldn't be merged until preview 7 ships

JunTaoLuo
JunTaoLuo commented Jun 25, 2019
View reviewed changes
eng/Versions.props
<GoogleProtobufPackageVersion>3.8.0</GoogleProtobufPackageVersion>
<GrpcAspNetCoreServerPackageVersion>0.1.21-pre1</GrpcAspNetCoreServerPackageVersion>
<GrpcToolsPackageVersion>1.21.0</GrpcToolsPackageVersion>
<GrpcAspNetCorePackageVersion>0.1.22-pre1</GrpcAspNetCorePackageVersion>
Copy link
Contributor Author

@JunTaoLuo JunTaoLuo Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note. Need to publish a version of this metapackage.

Copy link
Contributor Author

@JunTaoLuo JunTaoLuo Jun 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll update this to 0.1.22-pre2 when it gets published. this version is currently published to the nightly feed so we this PR is unblocked.

@ryanbrandenburg
Copy link
Contributor

ryanbrandenburg commented Jun 25, 2019 

##[error]src\SignalR\samples\SocialWeather\SocialWeather.csproj(0,0): error NU1604: Project dependency Google.Protobuf does not contain an inclusive lower bound. Include a lower bound in the dependency version to ensure consistent restore results.

Looks like this broke the SignalR samples because it removed the Google.Protobuf version.

@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Jun 25, 2019

Ahh... I thought we were the only ones using it.

@JunTaoLuo JunTaoLuo force-pushed the johluo/grpc-templates branch from ec9aa55 to 4da74df Compare June 25, 2019 18:06
@ryanbrandenburg
Copy link
Contributor

ryanbrandenburg commented Jun 25, 2019

Ahh... I thought we were the only ones using it.

It's good practice to do a "Ctrl-F" of the whole repo for references before removing anything (class, package, etc). Even if it SHOULDN'T be used by something else sometimes it is anyway.

@JunTaoLuo JunTaoLuo merged commit 82149f9 into master Jun 27, 2019
@JunTaoLuo JunTaoLuo deleted the johluo/grpc-templates branch June 27, 2019 22:04
@JunTaoLuo JunTaoLuo mentioned this pull request Jun 27, 2019
Closed
This was referenced Jul 1, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesNK JamesNK JamesNK approved these changes

@dougbu dougbu Awaiting requested review from dougbu

@ryanbrandenburg ryanbrandenburg Awaiting requested review from ryanbrandenburg

+1 more reviewer

@shirhatti shirhatti shirhatti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-grpc Includes: GRPC wire-up, templates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JunTaoLuo @shirhatti @ryanbrandenburg @JamesNK @Eilon