-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Closed
Labels
HTTP3area-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Milestone
Description
When a feature is requested from HttpContext and can't be found, it automatically falls back to get the feature from the connection.
I wonder if the same thing should happen with multiplexed QUIC streams. For example, IConnectionHeartbeatFeature, IConnectionCompleteFeature, IConnectionLifetimeNotificationFeature are set on the QUIC connection. But the transport context for a request is a stream. Those features aren't present.
A fix could be to have an extra level of fallback with IFeatureCollection.Get for multiplexed connections like QUIC:
- Sockets: HttpProtocol -> SocketConnection
- QUIC: HttpProtocol -> QuicStreamContext -> QuicConnectionContext
Metadata
Metadata
Assignees
Labels
HTTP3area-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions