-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Closed
Labels
DoneThis issue has been fixedThis issue has been fixedarea-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsarea-signalrIncludes: SignalR clients and serversIncludes: SignalR clients and servers🥌 Bedrock
Milestone
Description
Epic #10869
SignalR currently uses the "Bedrock" abstractions on the server side (ConnectionContext, etc.) but has a custom client-side abstraction (IConnectionFactory). Bedrock has evolved to support a client-side abstraction now so SignalR should update to use it (since it would be a breaking change).
The new client abstraction shape is:
public interface IConnectionFactory
{
ValueTask<ConnectionContext> ConnectAsync(System.Net.EndPoint endpoint, CancellationToken cancellationToken = default);
}Some elements to this:
- Add
IConnectionFactory(as above) somewhere (Connections.Abstractions? or a new library?) - Add
HttpEndpontsub-class ofSystem.Net.Endpoint(for use in theIConnectionFactory.ConnectAsyncmethod). - Configure the
TransferFormatin the constructor instead of in theConnectAsyncmethod? - Delete existing connection factory and change to use the new abstraction.
Metadata
Metadata
Assignees
Labels
DoneThis issue has been fixedThis issue has been fixedarea-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsarea-signalrIncludes: SignalR clients and serversIncludes: SignalR clients and servers🥌 Bedrock