Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/aspnetcore
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6e4519b
Choose a base ref
...
head repository: dotnet/aspnetcore
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0899769
Choose a head ref
  • 14 commits
  • 278 files changed
  • 11 contributors

Commits on Aug 5, 2021

  1. [Routing] Proactively checks constraints and complex parameters when …

    …building the DFA tree to trim unnecessary nodes (#33712)
    
    * Performs filtering of nodes while building the DFA matcher by evaluating literal nodes against parameter constraints and complex segments and discarding those that would never have produced a match.
    * Introduces a new interface that allows parameters to filter literal candidate nodes based on the parameter name or the literal node value
    * Implements the new interface in all our route constraints.
    javiercn authored Aug 5, 2021
    Configuration menu
    Copy the full SHA
    014a284 View commit details
    Browse the repository at this point in the history
  2. [main] Update dependencies from dotnet/efcore dotnet/runtime (#35057)

    [main] Update dependencies from dotnet/efcore dotnet/runtime
    dotnet-maestro[bot] authored Aug 5, 2021
    Configuration menu
    Copy the full SHA
    20947fe View commit details
    Browse the repository at this point in the history
  3. Support reloadable cshtml (#35017)

    As part of hot reload, types marked with `CreateNewOnMetadataUpdateAttribute` will result in a new type created rather than updating existing types. This works really well for .cshtml scenario where the type is never referenced by name, but rather using the path. This change adds the annotation to the cshtml file and does the runtime work to substitute the build-time compiled file with hot reloaded type on a hot reloaded event. 
    
    * Annotate cshtml files with `CreateNewOnMetadataUpdateAttribute` when targeting RazorLangVersion = 6.0
    * Additionally annotate cshtml files with an `RazorCompiledItemMetadataAttribute attribute that identifies the path (identifier)
    * Update RazorCompiledItemFeatureProvider to substitute a compiled type with a hot reloaded type
    * Clear more Razor specific caches as part of a hot reload event
    
    Fixes #34248
    pranavkm authored Aug 5, 2021
    Configuration menu
    Copy the full SHA
    e30d3c5 View commit details
    Browse the repository at this point in the history
  4. Support getting client certificate in Http/3 (#35016)

    * Implement GetClientCertAsync, ApplicationProtocol
    
    * Update src/Servers/Kestrel/Transport.Quic/src/Internal/QuicConnectionContext.FeatureCollection.cs
    
    Co-authored-by: Chris Ross <[email protected]>
    
    * Update src/Servers/Kestrel/Transport.Quic/src/Internal/QuicConnectionContext.FeatureCollection.cs
    
    Co-authored-by: Chris Ross <[email protected]>
    
    * Undo ITlsApplicationProtocolFeature
    
    * Feedback
    
    * Add (failing) test
    
    * Remove d.l
    
    * Fix test
    
    * Fix
    
    * Update src/Servers/Kestrel/Transport.Quic/test/QuicConnectionContextTests.cs
    
    Co-authored-by: James Newton-King <[email protected]>
    
    * Skip on non-win
    
    Co-authored-by: Chris Ross <[email protected]>
    Co-authored-by: James Newton-King <[email protected]>
    3 people authored Aug 5, 2021
    Configuration menu
    Copy the full SHA
    e5a0b2a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7d7aba7 View commit details
    Browse the repository at this point in the history
  6. Remove GetCallingAssembly usage (#35063)

    * Remove GetCallingAssembly usage
    - Today the WebApplicationBuilder tries to guess what the application name should be based on the immediate caller of the API using Assembly.GetCallingAssembly. This is because several components use the application name as a way to find the application assembly in order to do other things;
    - User secrets uses it to find the location of the  directory that holds configuration secrets.
    - MVC uses it as the assembly to start the search for controllers, pages, etc.
    - Identifty uses it to find application parts.
    This API is a bit fragile for internal refactoring (if the immediate caller is anything except for user code, then we will treat our own assembly as the calling assembly) and more importantly, it breaks in NativeAOT scenarios. Instead of the calling assembly, we now default to the entry assembly.
    - This will "break" in scenarios where the WebApplication is started in a library and the entry point is the host application (controllers will be scanned in potentially the wrong place by default or it will find the wrong controllers).
    - Now that we have the option that allows specifying the name of the application name via WebApplicationOptions, In the future, we're investigating ways that the compiler can inject the calling assembly via an attribute similar to [CallerMemberName] that would capture the calling assembly in a more reliable and AOT friendly way.
    - Added a test that asserts that the default application name is the entry assembly.
    - Updated the slnf file
    
    * PR feedback
    - Change the name of the overriding assembly since the entry assembly is the default.
    davidfowl authored Aug 5, 2021
    Configuration menu
    Copy the full SHA
    e3b6407 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d1b4435 View commit details
    Browse the repository at this point in the history
  8. Use Fedora queue that supports msquic (#35050)

    * Use Fedora queue that supports msquic
    
    * Run tests in PR quar
    
    * Quarantine all quic tests
    wtgodbe authored Aug 5, 2021
    Configuration menu
    Copy the full SHA
    dcc23d8 View commit details
    Browse the repository at this point in the history
  9. Remove redundant comments (#34067)

    Remove comments left over from code that has since been removed.
    martincostello authored Aug 5, 2021
    Configuration menu
    Copy the full SHA
    f135f25 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    fd9dfec View commit details
    Browse the repository at this point in the history
  11. Do not overwrite NoWarn in Mvc.Testing (#34592)

    * Do not overwrite NoWarn
    
    Do not overwrite the NoWarn property, and instead add to it.
    
    * Do not overwrite NoWarn
    
    Do not overwrite the NoWarn property, and instead add to it.
    
    * Do not overwrite NoWarn
    
    Do not overwrite the NoWarn property, and instead add to it.
    martincostello authored Aug 5, 2021
    Configuration menu
    Copy the full SHA
    814ddae View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. [main] Update dependencies from dotnet/efcore (#35071)

    [main] Update dependencies from dotnet/efcore
    dotnet-maestro[bot] authored Aug 6, 2021
    Configuration menu
    Copy the full SHA
    ab928c9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b7528e5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0899769 View commit details
    Browse the repository at this point in the history
Loading