Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/aspnetcore
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 62302a1
Choose a base ref
...
head repository: dotnet/aspnetcore
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 69f1ace
Choose a head ref
  • 4 commits
  • 9 files changed
  • 5 contributors

Commits on Sep 15, 2021

  1. Fix up solution file (#36383) 

    * Fix up solution file
* Add test project to solution file
    @captainsafia
    captainsafia authored Sep 15, 2021
    Configuration menu
    Copy the full SHA
    b5f3c54 View commit details
    Browse the repository at this point in the history

  2. Revert "Disable OSX10.14 Helix jobs for now (#36503)" (#36562) 

    This reverts commit 7b7f546.
    @wtgodbe
    wtgodbe authored Sep 15, 2021
    Configuration menu
    Copy the full SHA
    8be854c View commit details
    Browse the repository at this point in the history

  3. Avoid building the configuration sources twice - When making the inte… 

    …rnal host builder, we copy the sources from the ConfigurationManager to the internal IConfigurationBuilder and the HostBuilder creates. This results in building configuration twice which can be problematic for performance reasons. Instead, we copy over the already built configuration providers in a custom IConfigurationSource implementation. This change does means the looking at the list of sources will not match the original list of sources though. - Added a test (#36574)

Co-authored-by: David Fowler <[email protected]>
    @github-actions @davidfowl
    github-actions[bot] and davidfowl authored Sep 15, 2021
    Configuration menu
    Copy the full SHA
    5cc4786 View commit details
    Browse the repository at this point in the history

  4. Expose ParameterInfo for Minimal Actions API Explorer (#36439) (#36547) 

    * Expose ParameterInfo for Minimal Actions API Explorer

Populate the ParameterDescriptor for Minimal Actions parameters with
a type that implements IParameterInfoParameterDescriptor so that any
custom attributes on the parameter can be inspected.
Relates to #36438.

* Remove file-scoped namespace

Addresses review feedback.

Co-authored-by: Martin Costello <[email protected]>
    @captainsafia @martincostello
    captainsafia and martincostello authored Sep 15, 2021
    Configuration menu
    Copy the full SHA
    69f1ace View commit details
    Browse the repository at this point in the history
Loading