Skip to content

Enable Signing on MacOS#4624

Merged
ellahathaway merged 3 commits intodotnet:mainfrom
ellahathaway:macos-leg
Oct 30, 2024
Merged

Enable Signing on MacOS#4624
ellahathaway merged 3 commits intodotnet:mainfrom
ellahathaway:macos-leg

Conversation

@ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Oct 28, 2024

Related to dotnet/arcade#15181

@ellahathaway ellahathaway marked this pull request as ready for review October 29, 2024 21:05
@ellahathaway ellahathaway reopened this Oct 29, 2024
@ellahathaway
Copy link
Member Author

ellahathaway commented Oct 29, 2024

- task: ComponentGovernanceComponentDetection@0
displayName: Component Governance scan

- job: MacOS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually want signing for the PR builds?

Copy link
Member Author

@ellahathaway ellahathaway Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Running signing in PRs is necessary for testing the dry-run infra:

SignToolTask starting.
DryRun: True
Signing mode: Real
MicroBuild signing logs will be in (Signing*.binlog): /Users/runner/work/1/s/artifacts/log/Debug/
MicroBuild signing configuration will be in (Round*.proj): /Users/runner/work/1/s/artifacts/tmp/Debug/
Round 0: Signing 1 files.
Repacking 1 containers.
Repacking 1 containers in parallel.
Round 1: Signing 1 files.
Build artifacts signed and validated.
SignToolTask execution finished.
Publishing symbol packages to MSDL ...
Performing symbol publish  (Dry Run)..
SymbolServerPath: https://microsoftpublicsymbols.artifacts.visualstudio.com/DefaultCollection
ExpirationInDays specified: 3650
Symbol publish finished
Publishing symbol packages to SymWeb ...
Performing symbol publish  (Dry Run)..
SymbolServerPath: https://microsoft.artifacts.visualstudio.com/DefaultCollection
ExpirationInDays specified: 3650
Symbol publish finished

Copy link
Member

@missymessa missymessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM shipit

@ellahathaway ellahathaway merged commit 8f77385 into dotnet:main Oct 30, 2024
@ellahathaway ellahathaway deleted the macos-leg branch October 30, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants