Skip to content

[main] Update dependencies from dotnet/arcade #3844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dotnet-maestro merged 4 commits into from
Jun 16, 2023
Merged

[main] Update dependencies from dotnet/arcade #3844

dotnet-maestro merged 4 commits into from
Jun 16, 2023

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 14, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 350574dc-bd3d-4e3c-f3f0-08d8e97c775d
  • Build: 20230616.2
  • Date Produced: June 16, 2023 2:52:51 PM UTC
  • Commit: 4bbdd777f424056c823dabbe0212ed2ba0a6dddd
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
46017da 
…614.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23314.1 -> To Version 8.0.0-beta.23314.2
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 14, 2023

Notification for subscribed users from https://github.com/dotnet/arcade:

@riarenas

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

@riarenas
Copy link
Contributor

riarenas commented Jun 15, 2023 •
edited
Loading

@mmitche @ViktorHofer What should be the reaction in repos to dotnet/arcade@c279376...728a7d3?

D:\a\_work\1\s\.packages\microsoft.dotnet.arcade.sdk\8.0.0-beta.23314.2\tools\Workarounds.targets(79,5): error : PackageProjectUrl must be specified [D:\a\_work\1\s\src\Validation\src\Validation.csproj]
##[error].packages\microsoft.dotnet.arcade.sdk\8.0.0-beta.23314.2\tools\Workarounds.targets(79,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) PackageProjectUrl must be specified

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
62dd046 
…615.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23314.1 -> To Version 8.0.0-beta.23315.1
@mmitche
Copy link
Member

mmitche commented Jun 15, 2023

@tmat?

@tmat
Copy link
Member

tmat commented Jun 15, 2023

Looking

@tmat
Copy link
Member

tmat commented Jun 15, 2023

I think I need to fix this issue: dotnet/msbuild#3294

@tmat
Copy link
Member

tmat commented Jun 15, 2023

Hmm, or maybe not...

@tmat
Copy link
Member

tmat commented Jun 15, 2023

Found the issue.

IsCrossTargetingBuild is defined in Sdk.targets but bundled Source Link uses it in .props.

@tmat
Copy link
Member

tmat commented Jun 15, 2023

Fix: dotnet/sdk#33292

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 15, 2023

Nice find. Unfortunately that means that we need a newer SDK but as a policy we only update to signed preview / RTM releases. @mmitche should we revert the change in Arcade meanwhile or update to a nightly build in Arcade (after the PR is merged)?

@mmitche
Copy link
Member

mmitche commented Jun 15, 2023

Nice find. Unfortunately that means that we need a newer SDK but as a policy we only update to signed preview / RTM releases. @mmitche should we revert the change in Arcade meanwhile or update to a nightly build in Arcade (after the PR is merged)?

We should revert the change in arcade for now.

@ViktorHofer ViktorHofer mentioned this pull request Jun 16, 2023
Merged
dotnet-maestro bot added 2 commits June 16, 2023 08:33
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
6eb603f 
…616.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23314.1 -> To Version 8.0.0-beta.23316.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
b2ea18d 
…616.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 8.0.0-beta.23314.1 -> To Version 8.0.0-beta.23316.2
@dotnet-maestro dotnet-maestro bot merged commit 4b1c4b2 into main Jun 16, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-main-0990e80b-dca1-44db-a3db-6f960409fdc0 branch June 16, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@riarenas @mmitche @tmat @ViktorHofer