Skip to content

[main] Update dependencies from dotnet/arcade#3323

Merged
dotnet-maestro[bot] merged 3 commits intomainfrom
darc-main-80c0e3f1-1c35-4018-adc0-5c96765819a1
Aug 27, 2022
Merged

[main] Update dependencies from dotnet/arcade#3323
dotnet-maestro[bot] merged 3 commits intomainfrom
darc-main-80c0e3f1-1c35-4018-adc0-5c96765819a1

Conversation

@dotnet-maestro
Copy link
Copy Markdown
Contributor

@dotnet-maestro dotnet-maestro Bot commented Aug 26, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 350574dc-bd3d-4e3c-f3f0-08d8e97c775d
  • Build: 20220826.8
  • Date Produced: August 27, 2022 12:03:43 AM UTC
  • Commit: 14df52bae2c74fc850a8c40fe68ea5be5cd30116
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
21fa9f2 
…826.5

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22426.3 -> To Version 7.0.0-beta.22426.5
@dotnet-maestro
Copy link
Copy Markdown
Contributor Author

dotnet-maestro Bot commented Aug 26, 2022

Notification for subscribed users from https://github.com/dotnet/arcade:

@riarenas

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

@ghost
Copy link
Copy Markdown

ghost commented Aug 26, 2022

All windows helix legs failed with

xUnit.net Console Runner v2.4.2-pre.9+e627c231a5 (64-bit .NET 7.0.0-preview.7.22375.6)
  Discovering: Validation.Tests
  Discovered:  Validation.Tests
  Starting:    Validation.Tests
    Validation.Tests.RepoTests.BuildShouldNotChangeNonMicrosoft400CertsWhenSigning [FAIL]
      System.UnauthorizedAccessException : Access to the path 'dotnet.exe' is denied.
      Stack Trace:
           at System.IO.FileSystem.RemoveDirectoryRecursive(String fullPath, WIN32_FIND_DATA& findData, Boolean topLevel)
           at System.IO.FileSystem.RemoveDirectory(String fullPath, Boolean recursive)
        D:\a\_work\1\s\src\Validation\tests\TestRepoBuilder.cs(458,0): at Validation.Tests.TestRepoBuilder.Cleanup()
        D:\a\_work\1\s\src\Validation\tests\TestRepoBuilder.cs(464,0): at Validation.Tests.TestRepoBuilder.Dispose()
        D:\a\_work\1\s\src\Validation\tests\RepoTests.cs(296,0): at Validation.Tests.RepoTests.BuildShouldNotChangeNonMicrosoft400CertsWhenSigning()
        --- End of stack trace from previous location ---
    Validation.Tests.RepoTests.BuildShouldNotChangeNonMicrosoft400CertsWhenPostBuildSigning [FAIL]
      System.UnauthorizedAccessException : Access to the path 'dotnet.exe' is denied.
      Stack Trace:
           at System.IO.FileSystem.RemoveDirectoryRecursive(String fullPath, WIN32_FIND_DATA& findData, Boolean topLevel)
           at System.IO.FileSystem.RemoveDirectory(String fullPath, Boolean recursive)
        D:\a\_work\1\s\src\Validation\tests\TestRepoBuilder.cs(458,0): at Validation.Tests.TestRepoBuilder.Cleanup()
        D:\a\_work\1\s\src\Validation\tests\TestRepoBuilder.cs(464,0): at Validation.Tests.TestRepoBuilder.Dispose()
        D:\a\_work\1\s\src\Validation\tests\RepoTests.cs(415,0): at Validation.Tests.RepoTests.BuildShouldNotChangeNonMicrosoft400CertsWhenPostBuildSigning()
        --- End of stack trace from previous location ---
    Validation.Tests.RepoTests.BuildShouldUseDotNetCertifcateIfSetWithPostBuildSigning(useDotNetCert: True) [FAIL]
      System.UnauthorizedAccessException : Access to the path 'dotnet.exe' is denied.
      Stack Trace:
           at System.IO.FileSystem.RemoveDirectoryRecursive(String fullPath, WIN32_FIND_DATA& findData, Boolean topLevel)
           at System.IO.FileSystem.RemoveDirectory(String fullPath, Boolean recursive)
        D:\a\_work\1\s\src\Validation\tests\TestRepoBuilder.cs(458,0): at Validation.Tests.TestRepoBuilder.Cleanup()
        D:\a\_work\1\s\src\Validation\tests\TestRepoBuilder.cs(464,0): at Validation.Tests.TestRepoBuilder.Dispose()
        D:\a\_work\1\s\src\Validation\tests\RepoTests.cs(356,0): at Validation.Tests.RepoTests.BuildShouldUseDotNetCertifcateIfSetWithPostBuildSigning(Nullable`1 useDotNetCert)
        --- End of stack trace from previous location ---
    Validation.Tests.RepoTests.BuildShouldUseDotNetCertifcateIfSetWithPostBuildSigning(useDotNetCert: False) [FAIL]
      System.UnauthorizedAccessException : Access to the path 'dotnet.exe' is denied.
      Stack Trace:
           at System.IO.FileSystem.RemoveDirectoryRecursive(String fullPath, WIN32_FIND_DATA& findData, Boolean topLevel)
           at System.IO.FileSystem.RemoveDirectory(String fullPath, Boolean recursive)
        D:\a\_work\1\s\src\Validation\tests\TestRepoBuilder.cs(458,0): at Validation.Tests.TestRepoBuilder.Cleanup()
        D:\a\_work\1\s\src\Validation\tests\TestRepoBuilder.cs(464,0): at Validation.Tests.TestRepoBuilder.Dispose()
        D:\a\_work\1\s\src\Validation\tests\RepoTests.cs(356,0): at Validation.Tests.RepoTests.BuildShouldUseDotNetCertifcateIfSetWithPostBuildSigning(Nullable`1 useDotNetCert)
        --- End of stack trace from previous location ---
['Validation.Tests.dll' END OF WORK ITEM LOG: Command timed out, and was killed]

This PR includes the changes to the InstallDotnetCore task, and roll forward for the SBOM tooling.

tagging all authors for the incoming changes: @MattGal @rokonec @epananth

@MattGal
Copy link
Copy Markdown
Member

MattGal commented Aug 26, 2022

@riarenas I'm taking a look, logging looks like dotnet.exe is just still running which on Windows would prevent folder cleanup.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
2f4061f 
…826.7

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22426.3 -> To Version 7.0.0-beta.22426.7
@MattGal
Copy link
Copy Markdown
Member

MattGal commented Aug 26, 2022

@rokonec : I convinced myself that that change causes the problem, and rolled it back. It's really weird and thus far only breaking tests but out of an abundance of caution I took it back.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
85d5607 
…826.8

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.22426.3 -> To Version 7.0.0-beta.22426.8
@dotnet-maestro dotnet-maestro Bot merged commit 640bcc4 into main Aug 27, 2022
@dotnet-maestro dotnet-maestro Bot deleted the darc-main-80c0e3f1-1c35-4018-adc0-5c96765819a1 branch August 27, 2022 01:10
@rokonec
Copy link
Copy Markdown
Member

rokonec commented Aug 27, 2022

@MattGal : I must admit, I do not understand how could those code changes caused such test failure - windows only at that.
Do you think I can repro this failure locally by checkout particular git SHA and run test locally from VS?

@rokonec rokonec mentioned this pull request Aug 29, 2022
Merged
@MattGal
Copy link
Copy Markdown
Member

MattGal commented Aug 29, 2022

@MattGal : I must admit, I do not understand how could those code changes caused such test failure - windows only at that. Do you think I can repro this failure locally by checkout particular git SHA and run test locally from VS?

Yes, it's as simple as checking out arcade main and directly calling darc-update-dependencies with the appropriate build Id (any of the arcade builds made with the change included)

I suspect that this derives from "The Exec task calls cmd.exe instead of directly invoking a process."... while the scenario is somewhat artificial (not many folks delete their repos immediately after using arcade to install-dotnet.cmd) I was unwilling to take the risk here as passing arcade validation immediately starts pushing these changes into bellwether repos like runtime and Aspnet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MattGal @rokonec