Make the output of feature-flag-list readable#5457
Merged
premun merged 2 commits intodotnet:mainfrom Nov 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the logging configuration for the ProductConstructionService CLI tool to use a custom compact console formatter and changes the FeatureFlagListOperation to use direct console output instead of structured logging for informational messages.
- Adds
CompactConsoleLoggerFormatterto the CLI logging setup (matching patterns used in other tools in the repository) - Replaces structured logging calls (
_logger.LogInformation) with directConsole.WriteLinecalls in the feature flag listing operation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/ProductConstructionService.Cli/Options/Options.cs | Adds compact console logger formatter to the service registration |
| tools/ProductConstructionService.Cli/Operations/FeatureFlagListOperation.cs | Replaces structured logging with Console.WriteLine for informational output |
Comments suppressed due to low confidence (1)
tools/ProductConstructionService.Cli/Operations/FeatureFlagListOperation.cs:14
- The
_loggerfield is still injected and stored but only used for error logging (lines 51-52 and 61-62). Since other operations in the CLI (likeFeatureFlagGetOperationandFeatureFlagSetOperation) use structured logging consistently for both informational and error messages, this creates an inconsistent logging pattern. Consider either: (1) keeping structured logging for all messages to maintain consistency with other operations, or (2) if Console.WriteLine is the preferred approach, update all CLI operations consistently and remove the logger dependency where it's no longer needed.
private readonly ILogger<FeatureFlagListOperation> _logger;
dkurepa
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.