Changes of stable feeds should not be considered meaningful#5446
Merged
premun merged 4 commits intodotnet:mainfrom Nov 7, 2025
Merged
Changes of stable feeds should not be considered meaningful#5446premun merged 4 commits intodotnet:mainfrom
premun merged 4 commits intodotnet:mainfrom
Conversation
premun
commented
Nov 7, 2025
…angeAnalyzerTests.cs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the codeflow change analyzer to treat DARC-managed feed URL changes as non-meaningful changes during dependency flow, preventing unnecessary PR creation when only feed references change during backflow.
Key changes:
- Modified
GetExpectedContentsForBuildto extract and include DARC-managed feed URLs from build assets - Updated test data to include NuGet.config feed URL changes and asset location information
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Microsoft.DotNet.Darc/DarcLib/VirtualMonoRepo/CodeflowChangeAnalyzer.cs |
Added logic to extract DARC-managed feed URLs from build assets and include them in expected contents for change detection |
test/Microsoft.DotNet.DarcLib.Tests/VirtualMonoRepo/CodeflowChangeAnalyzerTests.cs |
Updated test to include NuGet.config feed changes and added asset location data to verify feed URL filtering works correctly |
adamzip
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5400