Increase wait time for checks during rebase scenario tests#5445
Merged
premun merged 2 commits intodotnet:mainfrom Nov 7, 2025
Merged
Increase wait time for checks during rebase scenario tests#5445premun merged 2 commits intodotnet:mainfrom
premun merged 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates helper classes under a unified ProductConstructionService.ScenarioTests.Helpers namespace, improving code organization and consistency in the scenario test project.
- Refactors helper class namespaces from
ProductConstructionService.ScenarioTestsandProductConstructionService.ScenarioTests.ObjectHelpersto the unifiedHelpersnamespace - Updates all using directives across test files to reference the new namespace
- Removes an unused
Azure.Coreimport from TestParameters.cs
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| TestParameters.cs | Removed unused Azure.Core import, added Helpers namespace import |
| ScenarioTestBase.cs | Updated import from ObjectHelpers to Helpers |
| ScenarioTests_Subscriptions.cs | Updated import from ObjectHelpers to Helpers |
| ScenarioTests_SdkUpdate.cs | Added Helpers namespace import |
| ScenarioTests_MergePolicies.cs | Added Helpers namespace import |
| ScenarioTests_Dependencies.cs | Updated import from ObjectHelpers to Helpers |
| ScenarioTests_DefaultChannels.cs | Added Helpers namespace import |
| ScenarioTests_CodeFlowRebase.cs | Added Helpers namespace import, updated wait attempts parameter, added explanatory comment |
| ScenarioTests_CodeFlowConflicts.cs | Added Helpers namespace import |
| ScenarioTests_CodeFlow.cs | Added Helpers namespace import |
| ScenarioTests_Channels.cs | Added Helpers namespace import |
| ScenarioTests_Builds.cs | Added Helpers namespace import |
| TestHelpers.cs | Changed namespace to Helpers |
| SubscriptionBuilder.cs | Changed namespace from ObjectHelpers to Helpers |
| Shareable.cs | Changed namespace to Helpers |
| Disposable.cs | Changed namespace to Helpers |
| DependencyCollectionStringBuilder.cs | Changed namespace from ObjectHelpers to Helpers |
| BuildRefComparer.cs | Changed namespace from ObjectHelpers to Helpers |
| AsyncDisposableValue.cs | Changed namespace to Helpers |
| AsyncDisposable.cs | Changed namespace to Helpers |
| EndToEndFlowLogic.cs | Added Helpers namespace import |
| CodeFlowScenarioTestBase.cs | Added Helpers namespace import |
adamzip
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also moves remaining helper classes to a folder that was already there
#5362