Publish merged comments earlier#5440
Merged
dkurepa merged 3 commits intodotnet:mainfrom Nov 7, 2025
Merged
Conversation
premun
previously approved these changes
Nov 7, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors comment handling in the dependency flow system to prevent comments from being posted to incorrect pull requests. The changes ensure that comments collected during forward flow tagging are posted immediately to the correct PR and then cleared, rather than potentially appearing in subsequently created PRs.
- Adds a
Reset()method toICommentCollectorto clear collected comments - Updates
TagForwardFlownPRsto post and reset comments immediately after tagging forward-flown PRs - Removes premature comment posting from
CheckPullRequestAsyncto avoid posting at incorrect times - Enables
ForceUpdatein VmrCodeflower when recreating previous flows to handle conflicts
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/ProductConstructionService/ProductConstructionService.DependencyFlow/PullRequestUpdater.cs |
Removes premature comment posting from CheckPullRequestAsync; updates TagForwardFlownPRs to accept PR URL parameter and post/reset comments immediately |
src/Microsoft.DotNet.Darc/DarcLib/CommentCollector.cs |
Adds Reset() method to clear collected comments |
src/Microsoft.DotNet.Darc/DarcLib/VirtualMonoRepo/VmrCodeflower.cs |
Sets ForceUpdate = true when recreating previous flows during conflict handling |
premun
previously approved these changes
Nov 7, 2025
premun
approved these changes
Nov 7, 2025
Member
|
I just spent 5 minutes trying to figure out how come it does not conflict with |
dkurepa
added a commit
to dkurepa/arcade-services
that referenced
this pull request
Nov 12, 2025
This reverts commit 9db3c69.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5263